frankenphp icon indicating copy to clipboard operation
frankenphp copied to clipboard

feat: FrankenPHP extensions

Open dunglas opened this issue 8 months ago • 5 comments

See: #1649 and https://github.com/dunglas/frankenphp-etcd

dunglas avatar Jun 17 '25 09:06 dunglas

image

this is gonna take awhile...

withinboredom avatar Jun 17 '25 21:06 withinboredom

Here is the docs PR: https://github.com/php/frankenphp/pull/1652

alexandre-daubois avatar Jun 19 '25 08:06 alexandre-daubois

The CI failure looks related to a change in SPC. Do you know what we're doing wrong @henderkes @crazywhalecc? It looks like we pass the --build-embed flag as usual.

dunglas avatar Jun 19 '25 17:06 dunglas

Seems that making --build-embed as optional causes this error. Workaround: move --build-embed at the end of command. I didn't expect that passing the parameter as InputOption::OPTIONAL would cause the extensions to be recognized as a value, maybe I need to revert the previous PR or find another way to avoid it being read as a value.

crazywhalecc avatar Jun 19 '25 17:06 crazywhalecc

should be fixed now, we reverted to a boolean flag

for some reason, the framework we used for option parsing defaults --build-embed to null, rather than true, like it does without a value to pass.

henderkes avatar Jun 20 '25 00:06 henderkes

🎉

alexandre-daubois avatar Jun 25 '25 08:06 alexandre-daubois