doc-en icon indicating copy to clipboard operation
doc-en copied to clipboard

Fix consistency for is_a()

Open victor-prdh opened this issue 3 years ago • 3 comments

Hi there, During my work for the translation on doc-fr, i saw reference/classobj/functions/is-a.xml seems not very consistent. It's speak about "object type" and "class" for the same things, it's maybe better to keep only one of those ?

Related PR on doc-fr here

Thanks !

victor-prdh avatar Oct 10 '22 20:10 victor-prdh

Hi @victor-prdh, we can pass both class name or object to this function. What do you think that we should keep both names, i.e. in manner class/object type. This way we could refer to both types of parameter.

jorgsowa avatar Oct 10 '22 21:10 jorgsowa

I also have a PR. #1789 I think we need to determine how to properly describe in the documentation. cc @cmb69

sy-records avatar Oct 11 '22 03:10 sy-records

Oh, didn't see your PR @sy-records, sorry ! I think the class/object type notation is a good compromise and give all the info with a correct readability.

You wanna take it on your PR and i close this one or we do it on this one ?

victor-prdh avatar Oct 11 '22 10:10 victor-prdh

relates to #506

mumumu avatar Dec 24 '22 02:12 mumumu

relates to #506

Thanks, i close this one !

victor-prdh avatar Dec 24 '22 08:12 victor-prdh