lock icon indicating copy to clipboard operation
lock copied to clipboard

Add support for fractional seconds timeout

Open mvorisek opened this issue 2 years ago • 3 comments

  • usleep supports microseconds resolution
  • Redis support milliseconds expire times

The changed method prototypes imply minor BC break if overriden, but no BC break in general, as float does accept (original) int values implicitly even with strict types.

  • composer.json format is fixed using https://github.com/ergebnis/composer-normalize

  • callable return types are templated to infer the real return type

mvorisek avatar Jul 30 '23 14:07 mvorisek

Hi, thank you for this MR. I was a on a holiday, but I'll have a look!

willemstuursma avatar Aug 07 '23 18:08 willemstuursma

Had a quick look, looks pretty fine, I'll have a closer look later this week.

Thank you, a very nice contribution!

willemstuursma avatar Aug 07 '23 18:08 willemstuursma

@willemstuursma may I please ask to review this PR?

mvorisek avatar Oct 20 '23 07:10 mvorisek