Gettext icon indicating copy to clipboard operation
Gettext copied to clipboard

Relative strings location path

Open Arzaroth opened this issue 5 years ago • 1 comments

Following the discussion in #256.

This addresses #208.

Arzaroth avatar Apr 24 '20 13:04 Arzaroth

As commented in https://github.com/php-gettext/Gettext/pull/256#issuecomment-618588669 I think this change introduces unnecessary complexity to the Code Scanner, because the function scanString() allows to achieve this.

In fact, scanFile() uses scanString() internally: https://github.com/php-gettext/Gettext/blob/master/src/Scanner/Scanner.php#L41

So I'm going to pause this for now. Thanks, anyway!

oscarotero avatar Apr 24 '20 15:04 oscarotero