www.php-fig.org icon indicating copy to clipboard operation
www.php-fig.org copied to clipboard

H1 are not shown

Open Jean85 opened this issue 7 years ago • 4 comments

While thinkering with the site, I've found a bug in markdown rendering: top level titles (AKA <h1>) are rendered at the HTML level, but are not visible:

Compare:

  • https://www.php-fig.org/bylaws/mission-and-structure/
  • https://github.com/php-fig/fig-standards/blob/master/bylaws/001-mission-and-structure.md

The Structure top title is not shown:

image

But it's present in HTML:

image

Maybe it's a CSS issue?

Jean85 avatar Feb 18 '19 23:02 Jean85

I think this was done by design by @reinink, see https://github.com/php-fig/www.php-fig.org/blob/54e3d54f15f92b34562fa6c056a1e4a242631e8a/source/_sass/blocks/markdown.scss#L8-L14

that said, I think we can easily reinstate them by adding some coherent styiling.

stefanotorresi avatar Feb 19 '19 13:02 stefanotorresi

Reinstating them would create duplication between the green band with the title and the beige part with the parsed markdown document. Maybe we can disable the h1 only if it's the first thing inside the parsed body?

Jean85 avatar Feb 19 '19 14:02 Jean85

I did it and it works, but the h1 are not styled at all! :smile:

I'll try to add some rules...

Jean85 avatar Feb 19 '19 21:02 Jean85

I think we need to fix this. The most important place where I feel duplication of headers is weird, is in the PSR documents and the personnel which are included from fig-standards.

I'm wondering if we can somehow expose the post type as a class somewhere in the page (body, markdown container), so we can do something like .post_type_psr .markdown h1:first-of-type {display: none;}

vdelau avatar Jul 13 '21 09:07 vdelau