damn-fast-priority-queue icon indicating copy to clipboard operation
damn-fast-priority-queue copied to clipboard

Merge changes from 3b

Open phoe opened this issue 4 years ago • 4 comments

@3b Will you mind if I review and merge your changes back into my branch? They seem backwards-compatible and should need just a bit of documentation.

phoe avatar Dec 10 '21 10:12 phoe

Been a while since i looked at this stuff, but i think merging it should be OK. I don't see any important looking changes in my local copy, just debugging noise. will try to take a closer look at it at some point though.

3b avatar Dec 13 '21 13:12 3b

is possible with this or with any damn-fast-*-priority-queue to dequeue and also get the priority number?

azimut avatar Dec 17 '21 23:12 azimut

It doesn't look like it, though that does sound like something that could be useful to have. Maybe the "found" value of dequeue and peek could be changed to return priority in place of T? (at least for the updatable variant, since it hadn't been merged yet. not sure if that would be too big a change for the existing ones or not.)

3b avatar Dec 18 '21 00:12 3b

I think it could work. We only depend on FOUNDP to be true right now, so changing it to a generalized boolean to convey more information would be a backwards compatible change.

On 18.12.2021 01:16, 3b wrote:

It doesn't look like it, though that does sound like something that could be useful to have. Maybe the "found" value of |dequeue| and |peek| could be changed to return priority in place of |T|? (at least for the updatable variant, since it hadn't been merged yet. not sure if that would be too big a change for the existing ones or not.)

— Reply to this email directly, view it on GitHub https://github.com/phoe/damn-fast-priority-queue/pull/13#issuecomment-997103415, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADSZHKVR3VXDM6OCDZKMQKLURPHETANCNFSM5JY2N7WA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

phoe avatar Dec 18 '21 05:12 phoe