phlask-map icon indicating copy to clipboard operation
phlask-map copied to clipboard

Create V.2 SearchBar Mobile

Open dibleauzah opened this issue 4 years ago • 10 comments

Is your feature request related to a problem? Please describe. As a user, I want to search for resources, landmarks, or addresses in order to find the best resource near me/around a certain location.

Describe the solution you'd like

  • A search bar with auto-fill addresses.
  • Searchable by landmarks (nice to have)
  • Searchable by Tap Name
  • Searchable by resource type (water, food, toilets, etc. with synonyms) (nice to have)

Describe alternatives you've considered XX

Additional context Figma Page See "Search Open" mock-up

Functionality: User clicks on the search icon in the header > search bar appears and field is selected so that users can directly start typing > search gets confirmed by hitting enter OR search bar gets closed by clicking on the closing icon (x)

dibleauzah avatar Dec 12 '21 12:12 dibleauzah

Update from Lisa: The closing icon "x" will get a different design, so stay tuned for that update

affabillyty avatar Jan 26 '22 00:01 affabillyty

Hi @rh9891, we're doing a quick inventory of issue statuses and wanted to see if you had any updates?

edlopez000 avatar Apr 13 '22 00:04 edlopez000

Hey @RNR1, we see you're assigned to this. Is this something you're actively working on?

freelyPheobe avatar Apr 25 '23 23:04 freelyPheobe

Hey @chethtrayen, we haven't seen you in a while. Is there support needed on this ticket?

freelyPheobe avatar Jul 18 '23 23:07 freelyPheobe

The search bar is currently not working on Phlask mobile. We'd like to make the search appear when the search button is clicked. An updated design is available here: https://www.figma.com/file/VGGqwl3Eq3GQIAO9I6LoNW/PHLASK?type=design&node-id=8036-117041&mode=design. Pull request #325 made progress on this ticket, but still contained bugs.

tomporvaz avatar Oct 18 '23 00:10 tomporvaz

Completed in PR #389

tomporvaz avatar Feb 07 '24 00:02 tomporvaz

Desktop looks good.

On mobile, I need to double check with Marine to make sure, but I believe that a user should have the ability to deselect the text box, like on desktop, by either pressing enter, selecting one of the search results, or tapping on the map (either pin or background). Deselecting the field would keep the search bar present with any current inputs, but remove the dark overlay over the map. If deselected it should also help with the keyboard remaining open as a user tries to scroll around.

Bit nitpicky, but I seem to get some strange behavior on pressing enter on both mobile and desktop that doesn't seem to have any rhyme or reason for cause. On pressing enter sometimes the popup with result remains opens and sometimes it closes.

lxh5395 avatar Feb 11 '24 14:02 lxh5395

@CmonUlot Please take a look at the search bar functionality and provide feedback about the intended behavior as noted in @lxh5395 review above.

tomporvaz avatar Feb 28 '24 00:02 tomporvaz

Work to be continued in issue #410.

tomporvaz avatar Apr 02 '24 01:04 tomporvaz