MathMLToCSharp icon indicating copy to clipboard operation
MathMLToCSharp copied to clipboard

Reusing code within other applications

Open toddmo opened this issue 8 years ago • 2 comments

I have factored out the classes to a class library, in order to use it in another project to investigate making it part of a .net expression tree builder (to build executable code as opposed to strings).

Code fixed / refactoring done. All build errors fixed. All runtime errors fixed. All 7 tests pass. Pull Request: tonight or tomorrow.

If you can't approve the request b/c of some of my changes involving changing the .Net Framework version(s) used, hopefully you can still use it to make a class library in the .Net Framework version that you prefer to use.

toddmo avatar Sep 18 '17 00:09 toddmo

Thank you for your contributions, it's my honor to cooperate with you! BTW, I'm interested in .net core too. Please feel free to create pr to this repo and I will be glad to review and merge your code.

philipxyc avatar Sep 19 '17 13:09 philipxyc

After all that, I ended up taking another approach.

Instead of wrapping the math ml elements, I wrapped. Net expression tree classes.

I transform the math ml into expression tree xml and deserialize into my class hierarchy. It creates a lambda and can even compile the expression into a delegate.

It handles the quadratic equation but I'm still unit testing it.

Thanks

On Sep 19, 2017 8:50 AM, "Min." [email protected] wrote:

Thank you for your contributions, it's my honor to cooperate with you! BTW, I'm interested in .net core too. Please feel free to create pr to this repo and I will be glad to review and merge your code.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/philipxyc/MathMLToCSharp/issues/2#issuecomment-330545337, or mute the thread https://github.com/notifications/unsubscribe-auth/AKuqjPHa8tvkFPG4YMapmOz5F6270amPks5sj8a3gaJpZM4PaVIx .

toddmo avatar Oct 04 '17 20:10 toddmo