Philip Craig

Results 399 comments of Philip Craig

Do you have a real world example that would use this?

I was hoping for an actual real world example. It seems to me that large fixed size arrays are quite uncommon, and even then you can usually use `Vec` anyway....

If `Big::try_from_ctx(src, ctx)` overflows the stack, then wrapping it in `Box::new` won't change anything. You need placement new or an equivalent (pass in a preallocated pointer for the destination of...

@m4b Discriminant values are stable for fieldless enums: https://doc.rust-lang.org/reference/items/enumerations.html#custom-discriminant-values-for-fieldless-enumerations

I agree that these traits should take `&self`, for the reasons that @willglynn gives. It should only consume `self` if there are benefits from reusing parts of self for the...

> I expect that calling the line to address functionality will be significantly more expensive than the rest of the functionality in this crate. It certainly will be slow if...

> In particular, I wonder whether `addr2line` could provide a convenience API for "create a new `Context` from a file" (maybe using `mmap` and `from_sections` internally if possible), [...] Something...

Yes, I think that `None` for the column means start of line, and we should document that better. I think that we may not be correctly handling line numbers of...

Right, but is there any useful distinction between those two? Do any other tools make that distinction?

> I think it does show it for the "left edge". Can you verify this please. I'm happy to expose "left edge" if it has meaning, but I looked in...