LCR-API icon indicating copy to clipboard operation
LCR-API copied to clipboard

fix detection of login finishing

Open Plyb opened this issue 3 years ago • 5 comments

The issue was that the landing page for LCR has changed to no longer include ids on any of the elements. Luckily though, they have a custom element we can wait for.

I also changed how the settings on the webdriver work since the default was not working on my machine.

Plyb avatar Jul 24 '22 23:07 Plyb

+1 Thanks for this.

Please pull this into master.

SpencerMKSmith avatar Feb 12 '23 17:02 SpencerMKSmith

looks like the element that @Plyb was looking for to wait for logon to complete doesn't exist anymore on the LCR main page (at least not for me). Recommend abandoning this PR

adamarnesen avatar Dec 26 '23 21:12 adamarnesen

I've fixed it in my fork: https://github.com/SpencerMKSmith/LCR-API-2

Also I've been trying to set it up with Docker, which needed the repo updated with Pip so it's available under lcr-api-2 now.

SpencerMKSmith avatar Dec 26 '23 22:12 SpencerMKSmith

I think there has been an additional change since your fork was updated. I've been working on it in my own fork as well if you want to take a look: https://github.com/adamarnesen/LCR-API-Plus

adamarnesen avatar Dec 26 '23 23:12 adamarnesen

I think there has been an additional change since your fork was updated. I've been working on it in my own fork as well if you want to take a look: https://github.com/adamarnesen/LCR-API-Plus

Actually, after a double check, looks like your version is working. I must have had a typo or something earlier when I tried it.

adamarnesen avatar Dec 26 '23 23:12 adamarnesen