vimium icon indicating copy to clipboard operation
vimium copied to clipboard

Link hints open Google's Privacy page in some cases

Open qu8n opened this issue 10 months ago • 1 comments

Describe the bug

On Reddit's feed, when typing f to toggle link hints, <space> to surface an overlapped hint, and [first letter of a two-letter hint], the Google Privacy Policy page is opened instead of the intended link.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Reddit's feed
  2. Tap f to toggle link hints
  3. Look for a two-letter link hint that is overlapped by another hint for a post a. If you don't see one, refresh the page or scroll down the feed until you do Image
  4. Tap <space> to rotate the stacking order of the link hints a. The previously-obscured hint should now be on top Image
  5. Tap the first letter of that two-letter hint (a in the example above)
  6. See the Google Privacy Policy page being opened instead of the intended link

Demo

(See my live key presses in the bottom left of the screen.) https://github.com/user-attachments/assets/20e9096d-7fa5-49c5-8aad-6a10fa887c33

Browser and Vimium version

  • This bug was observed in both Google Chrome and Brave:
    • Google Chrome: v135.0.7049.85 (Official Build) (arm64)
    • Brave: v1.77.97 with Chromium v135.0.7049.84 (Official Build) (arm64)
  • macOS: v14.6.1 (Build 23G93)
  • Vimium: v2.2.1

What I've tried

  • Restarted the browsers and computer
  • Reinstalled the Vimium extension
  • Confirmed that there is no conflicting Vimium options. What I have:
{
  "keyMappings": "map F LinkHints.activateModeToOpenInNewForegroundTab\nmap w LinkHints.activateModeToOpenInNewTab\nunmap <a-p>\nmap ap togglePinTab\nunmap r\nunmap x\nunmap J\nunmap K",
  "linkHintCharacters": "arstneiofpcluh",
  "scrollStepSize": 70,
  "settingsVersion": "2.2.1",
  "exclusionRules": [
    {
      "passKeys": "",
      "pattern": "https://docs.google.com/*"
    }
  ]
}

qu8n avatar Apr 15 '25 13:04 qu8n

Interestingly, I can reproduce the behavior on my end too - even without being logged in on reddit.

So far I've not been able to narrow down the cause... I don't know much about how the link hints are implemented yet, so it's difficult for me to trace it down with the debugger.

Reproduced on: Chromium Version 135.0.7049.84 (Official Build) Arch Linux (64-bit) Vimium 2.2.1

philg-dev avatar Apr 15 '25 21:04 philg-dev