vimium Fix z-index of Vimium elements

Fixes #4068

Description

This pull request addresses the issue where cookie banners or other DOM elements have a higher z-index than Vimium's hint markers, causing them to be obscured.

The code changes introduced in this PR puts all Vimium elements to the z-index's max value (2^31 - 1).

Link hint rotation is now done by reordering the DOM elements instead of the z-index. The order is the same as before (1.67).

This is an alternative implementation to #4310 as stated in this comment (thanks again, @raindUwU)

You can take a look at it on https://www.onetrust.com/cookie-banner-gallery/. There is 7-fold overlap in the top right corner to test rotation and a high z-index button in the left bottom corner that was obscured before.

Sep 28 '23 11:09 JulianDeal

Is there a reason why the PR was not yet approved or rejected? I'd be happy to make changes and update the PR but I need feedback.

Jan 15 '24 11:01 JulianDeal

@philc

Jan 25 '24 08:01 JulianDeal

Sorry for the delay. I'll take a look soon!

Mar 27 '24 17:03 philc

This will probably also fix #3603.

Mar 27 '24 18:03 philc

This works great. Thank you @JulianDeal! It had some merge conflicts, so I merged it manually in 8f3097eb2d538c8e6ca4d2cf38fce84d2cbc9788.

Apr 11 '24 03:04 philc