vimium icon indicating copy to clipboard operation
vimium copied to clipboard

Add feature move current tab to an existing window

Open dyckia opened this issue 4 years ago • 8 comments

Add feature move current tab to an existing window

Add a new command Vomnibar.moveTabToWindow which moves the current tab to an existing window.

Press key w which brings up the omnibar that displays a list of existing windows.

Once a window is selected, the current tab will be moved to the end position in the selected window, and focus is automatically switched to that tab.

  • Suggestions only display the windows that have the same state (normal/incognito).
  • Suggestions will automatically hide the window the tab is currently in.

dyckia avatar Sep 28 '21 13:09 dyckia

can this PR be merged?

developomp avatar Jan 18 '23 12:01 developomp

Hey @dyckia, sorry for the delay.

This seems like a reasonable feature and the implementation looks good. But for completeness, can you describe some of your use cases where you need this command?

Second, the code base has changed quite a bit recently and this will need to be reworked a bit to work again.

Third, there are some unrelated changes (the addition of closeOneTabOnLeft and other commands, scrollPageUp magnitude) which should be removed.

philc avatar Jul 23 '23 18:07 philc

Hi @philc @dyckia I am also interested in this feature quite a bit. If this PR is not panning out I would be willing to try and implement it myself, if it's fine by you.

IdoKendo avatar Feb 06 '24 10:02 IdoKendo

Hey @IdoKendo, I think now is a good time to consider this. Would take a stab?

philc avatar Feb 12 '25 22:02 philc

alternative implementation at https://github.com/philc/vimium/pull/4168

gliptak avatar Feb 13 '25 15:02 gliptak

Hey @IdoKendo, I think now is a good time to consider this. Would take a stab?

Hey @philc please see my implementation at #4417

IdoKendo avatar Feb 16 '25 11:02 IdoKendo

Ok great. I’m traveling this week and will review when I’m back.

On Sun, Feb 16, 2025 at 1:33 AM Ido Slonimsky @.***> wrote:

Hey @IdoKendo https://github.com/IdoKendo, I think now is a good time to consider this. Would take a stab?

Hey @philc https://github.com/philc please see my implementation at #4417 https://github.com/philc/vimium/pull/4417

— Reply to this email directly, view it on GitHub https://github.com/philc/vimium/pull/3925#issuecomment-2661388487, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACDFRM35NOUSWAPO6LODT2QBZPXAVCNFSM6AAAAABXAXJSTCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRRGM4DQNBYG4 . You are receiving this because you were mentioned.Message ID: @.***> [image: IdoKendo]IdoKendo left a comment (philc/vimium#3925) https://github.com/philc/vimium/pull/3925#issuecomment-2661388487

Hey @IdoKendo https://github.com/IdoKendo, I think now is a good time to consider this. Would take a stab?

Hey @philc https://github.com/philc please see my implementation at #4417 https://github.com/philc/vimium/pull/4417

— Reply to this email directly, view it on GitHub https://github.com/philc/vimium/pull/3925#issuecomment-2661388487, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACDFRM35NOUSWAPO6LODT2QBZPXAVCNFSM6AAAAABXAXJSTCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRRGM4DQNBYG4 . You are receiving this because you were mentioned.Message ID: @.***>

philc avatar Feb 17 '25 00:02 philc

I think the UX for this feature needs more discussion, so I've opened #4640.

philc avatar Feb 24 '25 06:02 philc