Spec Added new subclass with unified view based on SpDiffPresenter

SpDiffPresenter displays a split view. So I added a sub-class that displays a unified view called SpDiffUnifiedPresenter

Sep 12 '23 19:09 CarolinaMelendez

but this will not work. You need to include StUnifiedDiffChangesMorph in the correct place. (and call it SpUnifiedDiffChangesMorph) :P

Sep 14 '23 06:09 estebanlm

BTW carolina talk to us if you want to do your bachelor with us at Lille. You can talk to seb.

Sep 14 '23 20:09 Ducasse

Hi @estebanlm thanks for the review. I see I need to learn more. By the correct place of StUnifiedDiffChangesMorph you mean it should be in the same package together with DiffMorph ?

I would like to add that StUnifiedDiffChangesMorph is not a class I created, I just reuse that class because it already has the unified view there. I don't think I have the right to move the package. There is not a another way that make it works or is necessary to move the the location of StUnifiedDiffChangesMorph ?

Sep 18 '23 20:09 CarolinaMelendez

Hello, what is needed to accept this PR?

Oct 17 '23 11:10 jordanmontt

heh... nothing :) EDIT: I just saw there is a problem with dependencies.

Oct 17 '23 13:10 estebanlm

IAfter 10 min I could not find a way to rerun this PR :( What a dead interface

Jun 13 '24 07:06 Ducasse

So we will see if it breaks and in this case we will revert the PR

Jun 13 '24 07:06 Ducasse