Spec Fix scrollTo: on SpScrollableLayout not working

Add SpMorphicScrollableAdapter>>scrollTo: Add example in class documentation.

Mar 24 '23 15:03 hernanmd

Sorry for coming to this so late. there is a problem with this: in the Gtk implementation (which arrived first, this time :P) the scroll value is not a number between 0 and 1 but a real offset. To keep the same criteria, you need to receive also a real offsent then transform it into the percent value (which is what the 0..1 value is) in the adapter.

Apr 11 '23 09:04 estebanlm

@estebanlm

I've seen the changes should be applied to GtkScrollableAdapter>>scrollTo:. I should get then the maximum offset of the adapter which holds the scroller? Any hints?

Dec 14 '23 13:12 hernanmd

Sorry for coming to this so late. there is a problem with this: in the Gtk implementation (which arrived first, this time :P) the scroll value is not a number between 0 and 1 but a real offset. To keep the same criteria, you need to receive also a real offsent then transform it into the percent value (which is what the 0..1 value is) in the adapter.

I don't know how to adapt this method for the GTK version (I tried and it is not working). Could we have this integrated anyway as this is needed for the NewTools File Browser? Since @jecisc worked in the File Browser too what do you think ?

Feb 15 '24 17:02 hernanmd

Hernan is it not that the adpater should do the conversion following the way it is done in GTK backend. We specify X in the presenter and x goes to GTKbackend and a transformation of (X) to the morphic one?

Feb 15 '24 19:02 Ducasse

do not care about Gtk backend. I was thinking the opposite: you need to do the morphic backend to accept a real offset and internally (in the adapter) transform it into a percentage (since you will have the data needed there).

Feb 15 '24 21:02 estebanlm

Ok thanks. Now this is clearer.

Feb 16 '24 08:02 Ducasse

So what do we do with this one.

Jun 11 '24 15:06 Ducasse

I asked for some changes...

Jun 11 '24 15:06 estebanlm

I asked for some changes...

Sorry, I never got quite right how to implement them. Do you think we could sync this week?

Jun 11 '24 15:06 hernanmd

@hernanmd | @estebanlm can you take action? @estebanlm if you know and it takes you 10 min can you do it because I have the impression that @hernanmd does not understand or explain to him.

Jun 13 '24 07:06 Ducasse

yeah, we will see it as soon as we are both in the same place ;)

Jun 13 '24 07:06 estebanlm

ping! @hernanmd @estebanlm

Jun 25 '24 08:06 Ducasse

Broken test is unrelated

 ✗ #testUndeclared (165ms)
TestFailure: Found undeclared Variables: 
StSystemReporter in: SmalltalkCIPharo9>>#imageInfo
Gofer in: SCIGoferLoadSpec>>#basicLoadProjectOn:
ReleaseTest(TestAsserter)>>assert:description:resumable:
ReleaseTest(TestAsserter)>>assert:description:
ReleaseTest>>testUndeclared ...assert: remaining isEmpty description: description
ReleaseTest(TestCase)>>performTest

so I merge

Aug 01 '24 08:08 Ducasse

We have 2 failing tests about scrolling in the latest Pharo build. I think they come from here

Aug 01 '24 10:08 jecisc