NewTools icon indicating copy to clipboard operation
NewTools copied to clipboard

adding test to ensure it is possible to recompile code within a bloc with a dead home context twice

Open adri09070 opened this issue 1 year ago • 1 comments

Fixes #722

Test corresponding to this PR that needs to be merged first: https://github.com/pharo-project/pharo/pull/16319

adri09070 avatar Mar 20 '24 10:03 adri09070

@StevenCostiou

adri09070 avatar Mar 20 '24 14:03 adri09070

Hi @adri09070 This test is failing

StDebuggerActionModelTest
 ✗ #testRecompileMethodToInBlockContextWithDeadHomeTwice (7ms)
TestFailure: Got 'methodWithDeadBlockContext

	^ [ (1 + 1) printString ] yourself' instead of 'methodWithDeadBlockContext

	^ [ (1 + 1) printString ] yourself yourself'.
StDebuggerActionModelTest(TestAsserter)>>assert:description:resumable:
StDebuggerActionModelTest(TestAsserter)>>assert:description:
StDebuggerActionModelTest(TestAsserter)>>assert:equals:
StDebuggerActionModelTest>>testRecompileMethodToInBlockContextWithDeadHomeTwice ...assert: (self class >> #methodWithDeadBlockContext) ast sourceCode
		equals: methodWithBlockContextOriginalSource , ' yourself yourself'
StDebuggerActionModelTest(TestCase)>>performT

Ducasse avatar Jun 13 '24 07:06 Ducasse

Hi @Ducasse

Yes, this is because https://github.com/pharo-project/pharo/pull/16319 should be merged first. That's why I put it to draft

adri09070 avatar Jun 13 '24 07:06 adri09070

Kicking the build again

Ducasse avatar Jun 13 '24 07:06 Ducasse

This is strange since I integrated https://github.com/pharo-project/pharo/pull/16319

Ducasse avatar Jun 13 '24 07:06 Ducasse

May be https://github.com/pharo-project/pharo/pull/16319 is not available yet?

Ducasse avatar Jun 13 '24 07:06 Ducasse

Yes, I don't think https://github.com/pharo-project/pharo/pull/16319 is available yet. Moreover, the other PR has been merged into Pharo13 and this PR targets Pharo12. Both PRs should be merged into Pharo13 and Pharo12.

You can change the target branch of this PR to Pharo13 (I have the rights to do it, but I don't find the button to do it on Github) and if the test passes, you could later merge both PRs into Pharo12

adri09070 avatar Jun 13 '24 07:06 adri09070

Ah, I found the button

adri09070 avatar Jun 13 '24 08:06 adri09070

But we still need https://github.com/pharo-project/pharo/pull/16319 to be available. I don't know when new Pharo builds are built

adri09070 avatar Jun 13 '24 08:06 adri09070

Let us wait a bit and see.

Ducasse avatar Jun 13 '24 08:06 Ducasse

I do not understand because the test is failing

StDebuggerActionModelTest
 ✗ #testRecompileMethodToInBlockContextWithDeadHomeTwice (5ms)

Ducasse avatar Jun 13 '24 18:06 Ducasse

We just had to wait for the next Pharo build. The NewTools CI does not create a full image with the bootstrap.

Failing test is unrelated

adri09070 avatar Jun 14 '24 07:06 adri09070