invo icon indicating copy to clipboard operation
invo copied to clipboard

remove malfunctions

Open s-ohnishi opened this issue 2 years ago • 3 comments

I forgot to do some of the multiple changes. I also removed unnecessary comments and aligned quotes.

s-ohnishi avatar Jul 20 '23 06:07 s-ohnishi

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 5.06%. Comparing base (28b66fd) to head (199f592).

Files Patch % Lines
src/Controllers/CompaniesController.php 0.00% 2 Missing :warning:
src/Controllers/ProductsController.php 0.00% 2 Missing :warning:
src/Controllers/ProducttypesController.php 0.00% 2 Missing :warning:
Additional details and impacted files
@@           Coverage Diff            @@
##             master    #111   +/-   ##
========================================
  Coverage      5.06%   5.06%           
  Complexity      158     158           
========================================
  Files            31      31           
  Lines           948     948           
========================================
  Hits             48      48           
  Misses          900     900           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 20 '23 06:07 codecov[bot]

Added line #L52 was not covered by tests

I have multiple alerts like this, what should I do?

codecov/patch Failing after 1s — 0.00% of diff hit (target 5.06%)

Did I do something wrong? Should I make a patch and upload it?

s-ohnishi avatar Jul 20 '23 14:07 s-ohnishi

I'm preparing the next change (Bootstrap update), but I can't move forward if this is stuck.

s-ohnishi avatar Aug 24 '23 15:08 s-ohnishi

@Jeckerson please approve this PR, thanks.

aircodepl avatar Mar 28 '24 16:03 aircodepl

Added line #L52 was not covered by tests

I have multiple alerts like this, what should I do?

codecov/patch Failing after 1s — 0.00% of diff hit (target 5.06%)

Did I do something wrong? Should I make a patch and upload it?

Don't worry about that.

niden avatar Mar 28 '24 20:03 niden

Thank you @s-ohnishi

niden avatar Mar 29 '24 14:03 niden

I'm the one who should be thanking you. Now I can move on.

s-ohnishi avatar Mar 30 '24 01:03 s-ohnishi