Sharp.Xmpp icon indicating copy to clipboard operation
Sharp.Xmpp copied to clipboard
verified publisher icon pgstath

Allow XMPP Server to be different from JID domain

Open stevenlivz opened this issue 9 years ago • 2 comments

Added support for specifying the XMPP server to connect to when it s different from the XMPP hostname in the JID.

stevenlivz avatar Oct 27 '16 09:10 stevenlivz

Hi,

You have updated the nuget package too? Because I don't think this update is in the current version of Sharp.Xmpp hosted in the nuget server.

Thanks.

marchanddesable avatar Dec 10 '16 17:12 marchanddesable

@stevenlivz This is a really useful core PR, but it looks like your entire development process get pulled into it.

Usually the best approach to Git Flow is to create a branch in your repo for a PR, do the changes, and then create the PR from that branch. It looks like you created a PR from your master branch, so as you made additional changes, the PR grew out of control.

Would you mind cherry picking the first commit (9d5477a) off into a new branch and creating a new PR? Hopefully that could resolve folks problems (#65, #58, #34), and mine as well.

ddrinka avatar Apr 05 '19 09:04 ddrinka