sqlite_fdw icon indicating copy to clipboard operation
sqlite_fdw copied to clipboard

Add RPM specifiacation

Open mkgrgis opened this issue 2 years ago • 8 comments

Create rpm.spec. In continue of https://github.com/pgspider/sqlite_fdw/pull/39

Based on

  • https://rpm-software-management.github.io/rpm/manual/spec.html
  • https://github.com/scj643/sqlite_fdw/tree/master
  • rpm.spec from https://rhel.pkgs.org/9/postgresql-14-x86_64/sqlite_fdw_14-2.3.0-1.rhel9.x86_64.rpm.html

Thanks to @scj643 and @devrimgunduz

mkgrgis avatar Jul 24 '23 05:07 mkgrgis

@mkgrgis , Thank you for creating the PR.
Is it no problem to start the review?

@MinhLA1410 , Please review it if it is ready.

t-kataym avatar Jul 28 '23 07:07 t-kataym

@mkgrgis , Thank you for creating the PR. Is it no problem to start the review?

Yes, no problems. I'll study about RPM directive words if there will detected any problems.

mkgrgis avatar Jul 29 '23 16:07 mkgrgis

Hi @mkgrgis I tried to build rpm file from your spec. But it does not work. Could you please check again

error: parse error in expression
error: ${HOME}/sqlite_fdw/rpm.spec:25: bad %if condition

MinhLA1410 avatar Aug 10 '23 03:08 MinhLA1410

Thanks, @MinhLA1410 ! I'll try to get rpm environment, reproduce this problem and check again.

mkgrgis avatar Aug 11 '23 04:08 mkgrgis

Why are you trying to add spec file to sqlite_fdw repo? I'm already maintaining it in upstream repo. Also this spec file depends lots of things in the PostgreSQL RPM repo, it is not a standalone one.

devrimgunduz avatar Aug 11 '23 08:08 devrimgunduz

Hello, @devrimgunduz ! Thanks for reply and for rpms :-) . I try to add spec file because i want to get rpm files for my colleagues with some new features or with my experiments for user testing. Your rpm files with sqlite_fdw likes me because there is good implementation of lifecycle processes.

mkgrgis avatar Aug 11 '23 16:08 mkgrgis