Improve CI scripts

[MinhLA1410]

[mkgrgis]

Thanks, @MinhLA1410 ! I understand this testing architecture. As we have got now, postgres.h access problem from PostGIS was not resolved yet. This was also my big problem.

[MinhLA1410]

As we have got now, postgres.h access problem from PostGIS was not resolved yet. This was also my big problem.

@mkgrgis -san, I fixed it. But this PR does not contains the PostGIS testing of sqlite_fdw as the PR#96. So, If you need to prepare more configuration. Please let me know.

[mkgrgis]

@MinhLA1410, I have adopted my PR to this CI scripts, but there is still no properly installed PostGIS in temporary installation directory of a PostgreSQL version, see:

+ERROR: could not open extension control file "/home/runner/work/sqlite_fdw/sqlite_fdw/workdir/postgresql-12.16/tmp_install/usr/local/pgsql/share/extension/postgis.control": No such file or directory

This is my second big problem during GIS PR testing, first big problem with postgres.h was resolved.

[MinhLA1410]

@mkgrgis ,

This is my second big problem during GIS PR testing, first big problem with postgres.h was resolved.

You need to add additional postgis on sqlite_fdw Makefile like this.

check: temp-install
temp-install: EXTRA_INSTALL+=contrib/postgis
checkprep: EXTRA_INSTALL+=contrib/postgis

Could you try it?

[mkgrgis]

Could you try it?

Yes, @MinhLA1410 , thanks. Maybe

ifdef ENABLE_GIS
check: temp-install
temp-install: EXTRA_INSTALL+=contrib/postgis
checkprep: EXTRA_INSTALL+=contrib/postgis
endif

will be better? I have nogis test only for simple configuration and postgis test only for GIS mode.

[mkgrgis]

@MinhLA1410 , now there is temp-install problem, ifdef ENABLE_GIS works normal.

[MinhLA1410]

@mkgrgis ,

now there is temp-install problem, ifdef ENABLE_GIS works normal.

Could you get or print this log file '/home/runner/work/sqlite_fdw/sqlite_fdw/workdir/postgresql-12.16/tmp_install/log'. It contains the error message to investigate the reason.

[mkgrgis]

@MinhLA1410, all testing environment problems are resolved. Now I am doing experiments with TCs with PostGIS and without PostGIS.

[MinhLA1410]

@mkgrgis , Thank you for understanding.

[mkgrgis]

@MinhLA1410 -san , thanks for the CI scripts! You can borrow .github/workflows and GitHubActions to this PR from https://github.com/pgspider/sqlite_fdw/pull/96 and complete this PR with that version of sctipts. It will be nice, if this PR will be merged before my https://github.com/pgspider/sqlite_fdw/pull/96, because you are author of this CI implementation. Also you can detach PostGIS installation to separate script. Now we have 5000+ log lines in PostgreSQL building and this works ~ 6 minutes. PostGIS building works ~ 2.5 min. and have 2000+ log lines which are more observable.

[mkgrgis]

@MinhLA1410 , there is doubled program name in PostGIS mode:

/postgresql-12.16/src/bin/pg_config/pg_config

[MinhLA1410]

@mkgrgis

there is doubled program name in PostGIS mode:

No. The first pg_config is the directory. The second pg_config is the executable program.

[mkgrgis]

No. The first pg_config is the directory. The second pg_config is the executable program.

I am sorry, really there is other problem. I'll try to detach PostGIS installation script from PostgreSQL installation in some days.

[mkgrgis]

@MinhLA1410, PostGIS install scripts detached from PostgreSQL installation in my PR now. You can also borrow this solution. This decreases log output in PostgreSQL build work and can allow pass some compile option to PostGIS if this will be necessary in future.

[mkgrgis]

Thanks, @MinhLA1410 ! Your modifications of my idea looks fine. I am waiting on review of this CI by @t-kataym .

[MinhLA1410]

Thank you for understanding my modification, @mkgrgis.

[t-kataym]

@MinhLA1410 Thank you for your implementation. I will merge it into master.