pgrx icon indicating copy to clipboard operation
pgrx copied to clipboard

Consider refactoring `*const T` to `NonNull<T>` or `&T`

Open workingjubilee opened this issue 3 years ago • 1 comments

These files use *const to some T when they could probably actually use either:

  • NonNull<T>
  • &T
  • Option<NonNull<T>>
  • Option<&T>

The Optional forms of these types should be bit-equivalent to *const T. If in doubt, skip any cases where this conversion might seem incorrect due to a wonky lifetime concern, or use a more conservative form.

workingjubilee avatar Aug 12 '22 21:08 workingjubilee

Thinking about picking this up. Is it still needed?

therewillbecode avatar Jan 03 '25 22:01 therewillbecode