pgadmin4 icon indicating copy to clipboard operation
pgadmin4 copied to clipboard

The row number in result grid is deceptive and easy to lead mistake in data operation

Open xzer opened this issue 1 year ago • 5 comments

Please note that security bugs or issues should be reported to [email protected].

Describe the bug

The row number in result grid is very annoying, when the table has a number id (usually the PK) as the first column, it is very confusing to user which number is the row number and which number is the id from the table. Especially when the user is scrolling to right side to view the long columns, the row number column is stick at left side, it is very much easy to mislead user to treat the row number as the id of the table data.

I report this as a bug rather than feature request, because this defect has significant impact on data operation correctness.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'query panel'
  2. input SQL as "select * from some_table"
  3. See result grid

Expected behavior

The row number should be optional, there should be toggle to allow hide the row number column, and also there should be a global setting to allow hide the row number column.

Error message

N/A

Screenshots

image image

Desktop (please complete the following information):

  • OS: OSX Sonoma
  • Version: 8.9
  • Mode: Desktop or Server

Additional context

Add any other context about the problem here.

xzer avatar Aug 28 '24 06:08 xzer

I report this as a bug rather than feature request, because this defect has significant impact on data operation correctness.

It should be treated as UI design defect.

xzer avatar Aug 28 '24 06:08 xzer

@xzer You can check any sql editor, all have row numbers because it is very useful in most cases. Your request is first of a kind, no one had a problem with this before. So we're taking it as feature request to allow disabling the rownumbers.

adityatoshniwal avatar Aug 28 '24 07:08 adityatoshniwal

check the dbeaver

https://dbeaver.io/wp-content/uploads/2018/03/data_edit-450x220.png

Yes, it also has row number in the result grid, but it is in clear different cell style and background color, it is very clearly indicate the number is not a part of the data. But look above picture I pasted, they are almost same.

I would say, it may be not necessary to really "hide" it, but it need to be clearly differentiated from the data cells.

xzer avatar Aug 28 '24 07:08 xzer

check the dbeaver

https://dbeaver.io/wp-content/uploads/2018/03/data_edit-450x220.png

Yes, it also has row number in the result grid, but it is in clear different cell style and background color, it is very clearly indicate the number is not a part of the data. But look above picture I pasted, they are almost same.

I would say, it may be not necessary to really "hide" it, but it need to be clearly differentiated from the data cells.

Yes that can be done as well. Right now we add slight shadow to the right edge of row number.

adityatoshniwal avatar Aug 28 '24 07:08 adityatoshniwal

Right now we add slight shadow to the right edge of row number.

If you go back to check my pasted screenshot, I don't think the "slight shadow" can be easily differentiate from other cell border lines.

I was not using postgre and pgAdmin for several years, and I didn't remember I have any trouble on the UI previously, but this time it is really becoming a "bug" to me as I really picked wrong id numbers many times....

I think this is a recent (years?) UI change, and it is not a correct design decision, so I insist this should be treated as a bug rather than feature request.

xzer avatar Aug 29 '24 06:08 xzer

Feature implemented. Tested on snapshot build.

Env: OS - macOS 14.7 (Sonoma) Mode - Desktop

pravesh-sharma avatar Oct 14 '24 09:10 pravesh-sharma