pysen icon indicating copy to clipboard operation
pysen copied to clipboard
verified publisher icon pfnet

Update isort dependency to the latest version

Open RyutaroHashimoto opened this issue 2 years ago • 3 comments

Pysen only supports older versions of isort.

https://github.com/pfnet/pysen/blob/f9694670924687b864384c87858ec70dc3fb6402/setup.py#L49

RyutaroHashimoto avatar Mar 04 '24 20:03 RyutaroHashimoto

The versions specified here are ones confirmed to work with pysen. They also form part of the standardization provided by pysen. In many cases, you may need to use higher versions, in which case we recommend specifying versions individually. cf. https://github.com/pfnet/pysen?tab=readme-ov-file#what-isnt-pysen

linshokaku avatar Mar 05 '24 12:03 linshokaku

Thank you for your response. In our project, we're using Poetry for module management, and I'm currently facing issues with using the latest versions of mypy and isort. Could you please help me update the required versions in this section? https://github.com/pfnet/pysen/blob/f9694670924687b864384c87858ec70dc3fb6402/setup.py#L44-L51"

RyutaroHashimoto avatar Mar 10 '24 23:03 RyutaroHashimoto

Is extras=["lint"] specified in the pysen entry of pyproject.toml, which manages dependencies by poetry? If you want to specify your own version of linter, need to remove this specification. cf. https://github.com/pfnet/pysen?tab=readme-ov-file#install-pysen-with-your-choice-of-linter-versions

If possible, please provide the following information to help us solve the problem.

  • poetry config (pyproject.toml)
  • poetry version
  • python version

linshokaku avatar Mar 11 '24 03:03 linshokaku