Clement Boirie
Clement Boirie
>I manage to reproduce the failling tests locally after rebasing main in the branch, I'll look into it. Scratch that, it was an issue with the rebase 🥲
@danielbachhuber I've split the tests into dedicated files and update them to use `When I run` if they're expected to succeed. In https://github.com/wp-cli/cache-command/pull/89/commits/327d99a13cef3601fd8304006efaeb9396821e88 I added two debug statement to try...
@danielbachhuber I was finally able to fix the failures for the functional tests. It was related to the use of STDIN to get the new value, which didn't properly handle...
Hi @johnbillion, sorry for the delay. I didn't had the time to look at Daniel comments yet. I'll try to check them this week and finish up this PR for...
Hi @danielbachhuber, I've refactored the feature tests to address your feedbacks, this should be good to go. All tests workflows using MySQL are green, the ones with SQLite are failing,...
Hi, this PR should be ready for final review, the failling tests are related to SQLite errors and not to the changes in this PR.
@swissspidy I took a look at this, I'm not familiar with SQLite so I might be mistaking, but it seems that SQLite doesn't support `DELETE` statement for multiple tables like...
Turn out it's related to the escaping, like you suspected. Looking at the [`wpdb::esc_like`](https://github.com/petitphp/sqlite-database-integration/blob/037f6efe3ac27e9cda668e6d13eb087ed5471bce/wp-includes/sqlite/class-wp-sqlite-db.php#L110-L125) method in the SQLite integration plugin, they purposely remove the `addslashes` since SQLite doesn't care for...
Working on this issue.
Posted [a message](https://wordpress.slack.com/archives/C02KGN5K076/p1719871245311439) in the core-performance slack channel to : * clarify why the `tax_query` is considered a potential slow query and * if a performance handbook with specific info...