quick-find icon indicating copy to clipboard operation
quick-find copied to clipboard

debugger statement left inside of code

Open ghost opened this issue 9 years ago • 3 comments

A debugger statement was left in the code, which makes this plugin useless if you have developer mode open.

	function linkCheck(element){
		if(textSearch.linksOnly){
		  while (element) {
		  	debugger;
		    if (element.nodeName === 'A'){
				return true;
		    }
		    element = element.parentNode;
		  }
		  return false;
		} else {
			return true;
		}
	}

ghost avatar Nov 04 '16 19:11 ghost

@mattscoutapp thanks for bringing this up. You shouldn't hit the debugger statement unless you have a dev console open specific for the extension. This should be sandboxed from anything else. I'm in developer mode and have not seen any issues. But it should removed regardless.

peterdotjs avatar Nov 04 '16 20:11 peterdotjs

@peterdotjs Oh interesting, I hit the debugger while debugging a separate site. Maybe chrome dev tools has changed? I'll look over my config to see if it is anything in my specific setup.

ghost avatar Nov 04 '16 21:11 ghost

@mattscoutapp hmm...it a content script so it is loaded on the site itself. It has access to the DOM but I'm really surprised the JS would get triggered. Regardless, I'll try to get the extension updated (it's been a super long time since it's been updated) and update the thread.

Thanks!

peterdotjs avatar Nov 04 '16 21:11 peterdotjs