permitio
Ability to exclude pubsub data from the OpenTelemetry metrics
OpenTelemetry metrics endpoint provides data that I want to gather, but it also lists all the pubsub active clients and client data subscriptions. The latter two metrics take up the majority of the metrics available and in my case cause the responses to be very large while not very useful.
I would like to have the ability to turn off the verbose part of the metrics that it pubsub client data. One way of doing that would be to add a INCLUDE_PUBSUB_METRICS option which could be toggled on or off depending on ones needs.
Hey @andriusm , Thanks for opening the issue, the open telemetry is a new feature from what I recall. I'll let the team know about this feature request, besides of that if you are open to contribute it we'd be more than happy to provide some guidance 🤩
@omer9564 thanks for the quick response. I've already created a PR that would implement what I'm describing in this issue. But the github workflow App tests fails for some reason (https://github.com/permitio/opal/actions/runs/13239141636/job/36950411370) even though I don't think my changes should affect such test.
Thanks I know that @iwphonedo is working on improving the tests Also tagging this feature contributor @psardana 🥇
There seems to be an issue with cloning the repo while inside a container. I wonder if everything is ok with how secrets are setup in GitHub, here's a log excerpt:
- Clone tests policy repo to create test's branch
Cloning into 'opal-tests-policy-repo'...
Load key "/home/runner/work/opal/opal/app-tests/opal-tests-policy-repo-key": error in libcrypto
[email protected]: Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
./run.sh: line 50: cd: opal-tests-policy-repo: No such file or directory
Switched to a new branch 'test-2172317422'
remote: Permission to permitio/opal.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/permitio/opal/': The requested URL returned error: [40](https://github.com/permitio/opal/actions/runs/13259292476/job/37025969242?pr=758#step:10:41)3
@obsd