percona-toolkit icon indicating copy to clipboard operation
percona-toolkit copied to clipboard

Check undefined skip check slave lag schema change

Open cswingler opened this issue 6 years ago • 3 comments

The P parameter can be undefined in DSNs, resulting in the skip-check-slave-lag feature in pt-table-checksum puking trying to compare undefs.

This handles that check a little more safely.

This is exactly like #230 , but for pt-online-schema-change.

cswingler avatar Mar 04 '19 22:03 cswingler

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: svetasmirnova
:x: Chris Swingler


Chris Swingler seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Mar 04 '19 22:03 CLAassistant

the issue still exists.

hhgyu avatar Oct 16 '20 01:10 hhgyu

We may need to check if other tools require similar fix.

svetasmirnova avatar Sep 14 '22 12:09 svetasmirnova