percona-postgresql-operator icon indicating copy to clipboard operation
percona-postgresql-operator copied to clipboard
verified publisher icon percona

K8SPG-519 Extensions endpoint

Open timorusky opened this issue 1 year ago • 4 comments

K8SPG-519 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem: When installing custom extensions it is not possible to point to a custom s3 object storage endpoint.

Cause: The s3 SDK within the extension installer is only minimally configured, currently using default values.

Solution: Add an optional flag to the extension installer named endpoint and configure the s3 SDK appropriately.

CHECKLIST

Jira

  • [ ] Is the Jira ticket created and referenced properly?
  • [ ] Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • [ ] Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • [ ] Is an E2E test/test case added for the new feature/change?
  • [ ] Are unit tests added where appropriate?

Config/Logging/Testability

  • [ ] Are all needed new/changed options added to default YAML files?
  • [ ] Are the manifests (crd/bundle) regenerated if needed?
  • [ ] Did we add proper logging messages for operator actions?
  • [ ] Did we ensure compatibility with the previous version or cluster upgrade process?
  • [ ] Does the change support oldest and newest supported PG version?
  • [ ] Does the change support oldest and newest supported Kubernetes version?

timorusky avatar Feb 19 '24 18:02 timorusky

CLA assistant check
All committers have signed the CLA.

it-percona-cla avatar Feb 19 '24 18:02 it-percona-cla

Test name Status
custom-extensions failure
demand-backup passed
init-deploy passed
monitoring passed
operator-self-healing passed
scaling passed
scheduled-backup passed
self-healing passed
start-from-backup passed
telemetry-transfer passed
upgrade-minor passed
users passed
We run 12 out of 12

commit: https://github.com/percona/percona-postgresql-operator/pull/672/commits/ac94c37de5c061d4c3d25d69e51d29033b223385 image: perconalab/percona-postgresql-operator:PR-672-ac94c37de

JNKPercona avatar Feb 19 '24 19:02 JNKPercona

fixes #670

spron-in avatar Feb 22 '24 11:02 spron-in

@timorusky code LGTM, could you please check the custom-extensions test?

egegunes avatar Mar 14 '24 10:03 egegunes

@timorusky ping

egegunes avatar Mar 21 '24 10:03 egegunes

@egegunes due to the delayed response on my initial request, I've moved on to work with another operator and am no longer interested in pursuing the development of this feature. I am sorry for any inconvenience this may cause.

timorusky avatar Mar 22 '24 09:03 timorusky

@timorusky it's OK, we'll take over from here. thank you for your contribution

egegunes avatar Mar 28 '24 10:03 egegunes