PerconaFT icon indicating copy to clipboard operation
PerconaFT copied to clipboard

Fix PS-4328, a crash that occurs when out of locks

Open prohaska7 opened this issue 6 years ago • 0 comments

PS-4328 describes a crash in the FT locktree that is caused when the memory used for locks exceeds the locktree limit AND pending lock requests are retried. The lock request retry logic did not handle this case and crashed.

This pull request:

Contains locktree test cases that expose this problem. Contains ydb test cases that expose this problem. These test cases shows that DB->put can return the TOKUDB_OUT_OF_LOCKS error when the locktree memory exceeds its limit. This is a normal case. Contains a bug fix in the lock request retry logic that correctly handles the TOKUDB_OUT_OF_LOCKS error by terminating the pending lock request with the TOKUDB_OUT_OF_LOCKS error. The application logic using the FT library SHOULD handle this error. Tools: Ubuntu 19.10, Clang 7,8,9, Gcc 7,8,9, Cmake 3.14

Copyright (c) 2020, Rik Prohaska All rights reserved.

Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:

Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

prohaska7 avatar Apr 11 '20 14:04 prohaska7