batch-smart-resize icon indicating copy to clipboard operation
batch-smart-resize copied to clipboard

Warn on overwriting?

Open unhammer opened this issue 6 years ago • 3 comments

It'd be nice if this could warn before overwriting existing files.

unhammer avatar Jun 14 '19 19:06 unhammer

Thanks for the suggestion @unhammer. I agree that is an important thing.

I'd welcome a PR for this. Otherwise I'll try to figure out how to do it when I get some free time to work on this project.

per1234 avatar Jun 15 '19 00:06 per1234

I actually did this in my fork ( https://github.com/unhammer/batch-smart-resize/commit/010682b6c41fe86a95058120d412b891f6f09f0a ), but I ended up changing the code style quite a bit (my laptop has a short monitor and I prefer seeing full functions in one screenful =P). I also swapped default to JPG 1600x1600, but if you want I can make a PR with your defaults?

(Also, would be nice if GIMP could remember the last used settings, other filters do this so should be possible?)

unhammer avatar Jun 15 '19 06:06 unhammer

I'd be receptive to an improvement in the code style if it's in a separate, dedicated commit that doesn't make any functional changes.


EDIT: saving the unhammer@010682b patch here to make sure it won't get lost: 010682b6c41fe86a95058120d412b891f6f09f0a.patch.txt

per1234 avatar Jun 15 '19 07:06 per1234