s5cmd icon indicating copy to clipboard operation
s5cmd copied to clipboard

Support AWS `sso_session` setup

Open matan129 opened this issue 2 years ago • 2 comments

Hi, this is a simple change - I have a setup with AWS SSO, specifically sso_session (docs).

It got implemented in the AWS Go SDK fairly recently https://github.com/aws/aws-sdk-go/pull/4885 - v1.44.298

Since it's just a patch version upgrade, it was just a simple matter of bumping the version.

Thanks

matan129 avatar Dec 06 '23 13:12 matan129

Just ran into this myself. Please review and cut this into a new release.

tmehlinger avatar Jan 13 '24 18:01 tmehlinger

Hi @igungor, can we get this merged? Thanks :pray:

matan129 avatar Jan 31 '24 10:01 matan129

Is there any update to this PR? Really looking forward to supporting S3 Express!

billzhang3046 avatar Jun 13 '24 04:06 billzhang3046

Hi @ahmethakanbesel, any change for getting it merged?

matan129 avatar Jun 13 '24 07:06 matan129

Closes #726.

denizsurmeli avatar Jun 28 '24 16:06 denizsurmeli

Hi, thanks for your contribution. Can you please follow the style guide in the PR title, since the title will be the commit message in the master branch.

denizsurmeli avatar Jun 28 '24 16:06 denizsurmeli

Done

matan129 avatar Jun 28 '24 16:06 matan129

Hi, with the following go build:

go version go1.22.1 darwin/arm64

When run

go mod tidy && go mod vendor

The following diff occurs.

diff --git a/go.sum b/go.sum
index cf4b72f..53f6cf4 100644
--- a/go.sum
+++ b/go.sum
@@ -1,6 +1,5 @@
 github.com/VividCortex/ewma v1.2.0 h1:f58SaIzcDXrSy3kWaHNvuJgJ3Nmz59Zji6XoJR/q1ow=
 github.com/VividCortex/ewma v1.2.0/go.mod h1:nz4BbCtbLyFDeC9SUHbtcT5644juEuWfUAUnGx7j5l4=
-github.com/aws/aws-sdk-go v1.44.256 h1:O8VH+bJqgLDguqkH/xQBFz5o/YheeZqgcOYIgsTVWY4=
 github.com/aws/aws-sdk-go v1.44.256/go.mod h1:aVsgQcEevwlmQ7qHE9I3h+dtQgpqhFB+i8Phjh7fkwI=
 github.com/aws/aws-sdk-go v1.44.298 h1:5qTxdubgV7PptZJmp/2qDwD2JL187ePL7VOxsSh1i3g=
 github.com/aws/aws-sdk-go v1.44.298/go.mod h1:aVsgQcEevwlmQ7qHE9I3h+dtQgpqhFB+i8Phjh7fkwI=

The same diff occurs with go 1.19.1. Can you please go mod tidy && go mod vendor and add the changes to the PR ? Thanks.

denizsurmeli avatar Jul 03 '24 06:07 denizsurmeli

Fixed

matan129 avatar Jul 03 '24 07:07 matan129