Paul Annesley
Paul Annesley
I wonder if we could pack the IOPS into `RootVolumeType ` like `gp3:6000`. Although I think `Fn::Split` & `Fn::Select` would struggle with the optionality of the `:6000` suffix :( I...
Yeah nice. I used aws-sdk-go-v2 a few times before it was GA, and it seemed nicer than v1. It was in beta/preview status for ages, I think I missed, or...
Hey @jesseduffield — that sounds useful. Are you proposing we bump the version of docker-compose that gets installed inside the `buildkite/agent:*` docker images? e.g. here: https://github.com/buildkite/agent/blob/6fec074dce224d039821b3d650eb3f4062e69b24/packaging/docker/ubuntu-20.04-linux/Dockerfile#L4 I _think_ that's the...
Thanks for the very clear write-up @austinguo550! I did some digging, and found this: https://github.com/buildkite/agent/blob/6fec074dce224d039821b3d650eb3f4062e69b24/agent/plugin/plugin.go#L139-L144 So, `-buildkite-plugin` _and_ `-buildkite-plugin.git` suffixes are trimmed, whereas the `.git` suffix is not trimmed if...
Closing for now, but no reason somebody shouldn't dust this off and open it again.
I've been doing some digging, and these extra `CR` characters come from the https://github.com/creack/pty library that we use to expose a [Pseudoterminal](https://en.wikipedia.org/wiki/Pseudoterminal) to the commands running in the build job....
I think this is fundamental to running in PTY mode. The PTY driver in the kernel is mapping `LF` → `CR LF`, and terminal emulators (Terminal.app / xterm / iTerm2...
I've tested putting `stty -onlcr` in a Buildkite command step… Here's the HTML-rendered log, looks fine: Here's the raw log as rendered by Firefox 118: And here's the terminal output...
Perhaps look into the code differences between `irc_machine` and the fork at https://github.com/99designs/agent99
Here's the relevant code: https://github.com/pda/flexihash/blob/8403c28a5453146c391992dc25cc364df365a8f5/src/Flexihash.php#L95-L100 Based on that, and some very hazy memory: For a given weight `w`, that target is `w` times more likely to be picked compared to...