pbek
(Windows) Some buttons get localised to system locale
Expected behaviour
All buttons should have the same locale as the rest of the software.
Actual behaviour
See https://i.imgur.com/ZaeANlj.png, https://i.imgur.com/2Uq3bOX.png. As you can see, the Yes/No buttons are localised to "Jā" and "Nē", which is Latvian for Yes/No. Similar issue can be seen in settings - https://i.imgur.com/YhvNgAO.png (Labi/Atcelt - Confirm/Cancel).
Steps to reproduce
Have Windows with non-English Region set I think. My Windows currently has the enGB locale set, QOwnNotes is set to English. My Region is set to Latvia and my main keyboard language is Latvian.
Those might be translated in Qt directly. You didn't post your settings dump (can you please fill out the issue template). Which language do you have selected in QOwnNotes?
At that moment I didn't post it because it contained some information I would rather not share (remote domains, usernames, calendar lists), but here it is. QOwnNotes is in English.
QOwnNotes Debug Information
General Info
Current Date: sestd. janv. 6 16:35:35 2018
Version: 18.01.1
Build date: Jan 6 2018
Build number: 3421
Platform: windows
Operating System: Windows 10
Build architecture: i386
Current architecture: x86_64
Release: AppVeyor
Qt Version (build): 5.7.1
Qt Version (runtime): 5.7.1
Portable mode: no
Settings path / key: \HKEY_CURRENT_USER\Software\PBE\QOwnNotes
Application database path: C:\Users\zingmars\AppData\Roaming\PBE\QOwnNotes\QOwnNotes.sqlite
Application arguments: C:\Program Files\qOwnNotes, \QOwnNotes.exe, --after-update, C:\Users\zingmars\AppData\Local\Temp\QOwnNotes-b12708-updater.bat
Qt Debug: 0
Locale (system): lv_LV
Locale (interface): en
Icon theme: breeze-dark-qownnotes
Notes in current note folder: 5
Enabled scripts: 0
Server Info
serverUrl: ...
appIsValid: yes
notesPathExists: yes
serverVersion: 13.0.0.5
appVersion: 17.5.0
Note folders
currentNoteFolderId: 1
Note folder default
id: 1
isCurrent: yes
activeTagId: -1
localPath: C:\Cloud\Notes
remotePath: Notes
isShowSubfolders: no
isUseGit: yes
activeNoteSubFolder name: empty
database file: C:\Cloud\Notes\notes.sqlite
Enabled scripts
Settings
AboutDialog/geometry: <binary data>
ActiveNoteHistoryItem: empty
Debug/fakeOldVersionNumber: false
Debug/fileLogging: false
Editor/CurrentSchemaKey: EditorColorSchema-cdbf28fc-1ddc-4d13-bb21-6a4043316a2f
Editor/autoBracketClosing: true
Editor/autoBracketRemoval: true
Editor/editorWidthInDFMOnly: true
Editor/highlightCurrentLine: true
LastUpdateCheck: 2018-01-06T16:03:30
MainWindow/geometry: <binary data>
MainWindow/mainToolBar.iconSize: 24
MainWindow/menuBarGeometry: <binary data>
MainWindow/noteTextEdit.code.font: Courier New,9,-1,2,50,0,0,0,0,0
MainWindow/noteTextEdit.font: MS Shell Dlg 2,8.25,-1,5,50,0,0,0,0,0
MainWindow/noteTextView.code.font: Courier New,9,-1,2,50,0,0,0,0,0
MainWindow/noteTextView.font: MS Shell Dlg 2,8.25,-1,5,50,0,0,0,0,0
MainWindow/noteTextView.rtl: false
MainWindow/showNotesFromAllNoteSubFolders: true
MessageBoxOverride/remove-notes: 16384
PiwikClientId: <hidden>
SearchEngineId: 2
SettingsDialog/geometry: <binary data>
SettingsDialog/mainSplitterState: <binary data>
ShowSystemTray: true
StartHidden: true
UpdateDialog/geometry: <binary data>
WelcomeDialog/geometry: <binary data>
acceptAllExternalModifications: false
allowDifferentNoteFileName: false
allowNoteEditing: true
allowOnlyOneAppInstance: true
appMetrics/disableAppHeartbeat: true
appMetrics/disableTracking: true
appMetrics/notificationShown: true
closeTodoListAfterSave: false
cryptoKey: <hidden>
currentNoteFolderId: 1
currentWorkspace: e6eca7d8-4b61-4245-9700-ae34e16184a3
cursorWidth: 1
customNoteFileExtensionList: empty
darkMode: true
darkModeColors: true
darkModeTrayIcon: true
defaultNoteFileExtension: md
disableAutomaticUpdateDialog: false
dockWasInitializedOnce: true
externalEditorPath: empty
fullyHighlightedBlockquotes: false
gitCommitInterval: 30
gitExecutablePath: empty
gitLogCommand: empty
ignoreAllExternalModifications: false
ignoreAllExternalNoteFolderChanges: false
imageScaleDown: false
imageScaleDownMaximumHeight: 1024
imageScaleDownMaximumWidth: 1024
insertTimeFormat: empty
interfaceLanguage: en
internalIconTheme: true
itemHeight: 15
markdownHighlightingEnabled: true
networking/ignoreSSLErrors: false
networking/proxyType: 2
newNoteAskHeadline: false
noteSaveIntervalTime: 10
noteSubfoldersPanelDisplayAsFullTree: true
noteSubfoldersPanelHideSearch: false
noteSubfoldersPanelOrder: 0
noteSubfoldersPanelShowFullPath: false
noteSubfoldersPanelShowNotesRecursively: false
noteSubfoldersPanelShowRootFolderName: true
noteSubfoldersPanelSort: 0
notesPanelOrder: 0
notesPanelSort: 0
notesPath: C:/Cloud/Notes
notifyAllExternalModifications: false
ownCloud/password: ...
ownCloud/serverUrl: ...
ownCloud/supportEnabled: true
ownCloud/todoCalendarBackend: 3
ownCloud/todoCalendarCalDAVPassword: ...
ownCloud/todoCalendarCalDAVServerUrl: ...
ownCloud/todoCalendarCalDAVUsername: ...
ownCloud/todoCalendarEnabledList: ...
ownCloud/todoCalendarEnabledUrlList: ...
ownCloud/todoCalendarUrlList: ...
ownCloud/userName: ...
previousWorkspace: f5d5e71e-3a8e-4aea-99f7-e1df393a0c3e
restoreCursorPosition: true
savedSearches/noteFolder-1: ...
showMenuBar: true
showStatusBar: true
taggingShowNotesRecursively: false
tagsPanelHideSearch: false
tagsPanelOrder: 0
tagsPanelSort: 0
toolbar/1/items: action_New_note, action_Find_note, action_Remove_note, action_Open_note_in_external_editor, , action_Back_in_note_history, action_Forward_in_note_history, , action_Find_text_in_note, actionReplace_in_current_note, , actionShow_versions, actionShow_trash, actionShare_note, , actionOpen_List
toolbar/1/name: mainToolBar
toolbar/1/title: main toolbar
toolbar/2/items: actionFormat_text_bold, actionFormat_text_italic, actionStrike_out_text, actionInsert_code_block, actionInsert_block_quote
toolbar/2/name: formattingToolbar
toolbar/2/title: formatting toolbar
toolbar/3/items: actionInsert_Link_to_note, actionInsert_image, actionInsert_current_time
toolbar/3/name: insertingToolbar
toolbar/3/title: inserting toolbar
toolbar/4/items: action_Encrypt_note, actionEdit_encrypted_note, actionDecrypt_note
toolbar/4/name: encryptionToolbar
toolbar/4/title: encryption toolbar
toolbar/5/items: actionWorkspaceComboBox, actionStore_as_new_workspace, actionRemove_current_workspace, actionRename_current_workspace, actionSwitch_to_previous_workspace, actionUnlock_panels, , actionToggle_distraction_free_mode, action_Increase_note_text_size, action_Decrease_note_text_size, action_Reset_note_text_size
toolbar/5/name: windowToolbar
toolbar/5/title: window toolbar
toolbar/6/items: action_Quit
toolbar/6/name: quitToolbar
toolbar/6/title: quit toolbar
toolbar/size: 6
useUNIXNewline: false
workspace-e6eca7d8-4b61-4245-9700-ae34e16184a3/name: full
workspace-e6eca7d8-4b61-4245-9700-ae34e16184a3/noteSubFolderDockWidgetVisible: true
workspace-e6eca7d8-4b61-4245-9700-ae34e16184a3/windowState: <binary data>
workspace-f5d5e71e-3a8e-4aea-99f7-e1df393a0c3e/name: minimal
workspace-f5d5e71e-3a8e-4aea-99f7-e1df393a0c3e/noteSubFolderDockWidgetVisible: true
workspace-f5d5e71e-3a8e-4aea-99f7-e1df393a0c3e/windowState: <binary data>
workspaces: e6eca7d8-4b61-4245-9700-ae34e16184a3, f5d5e71e-3a8e-4aea-99f7-e1df393a0c3e
System environment
ALLUSERSPROFILE: C:\ProgramData
APPDATA: C:\Users\zingmars\AppData\Roaming
CommonProgramFiles: C:\Program Files (x86)\Common Files
CommonProgramFiles(x86): C:\Program Files (x86)\Common Files
CommonProgramW6432: C:\Program Files\Common Files
COMPUTERNAME: ...
ComSpec: C:\WINDOWS\system32\cmd.exe
destination: "C:\Program Files\qOwnNotes"
HOMEDRIVE: C:
HOMEPATH: \Users\zingmars
LOCALAPPDATA: C:\Users\zingmars\AppData\Local
LOGONSERVER: \\...
NUMBER_OF_PROCESSORS: 8
OneDrive: C:\Users\zingmars\OneDrive
OS: Windows_NT
Path: ...
PATHEXT: .COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC
PROCESSOR_ARCHITECTURE: x86
PROCESSOR_ARCHITEW6432: AMD64
PROCESSOR_IDENTIFIER: Intel64 Family 6 Model 94 Stepping 3, GenuineIntel
PROCESSOR_LEVEL: 6
PROCESSOR_REVISION: 5e03
ProgramData: C:\ProgramData
ProgramFiles: C:\Program Files (x86)
ProgramFiles(x86): C:\Program Files (x86)
ProgramW6432: C:\Program Files
PROMPT: $P$G
PSModulePath: C:\Program Files\WindowsPowerShell\Modules;C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules
PUBLIC: C:\Users\Public
qownnotesCommand: "C:\Program Files\qOwnNotes"\QOwnNotes.exe --after-update C:\Users\zingmars\AppData\Local\Temp\QOwnNotes-b12708-updater.bat
SESSIONNAME: Console
source: C:\Users\zingmars\AppData\Local\Temp\QOwnNotes-b12708.zip
SystemDrive: C:
SystemRoot: C:\WINDOWS
TEMP: C:\Users\zingmars\AppData\Local\Temp
TMP: C:\Users\zingmars\AppData\Local\Temp
unzipCommand: C:\Users\zingmars\AppData\Local\Temp\QOwnNotes-b12708-unzip.exe -o C:\Users\zingmars\AppData\Local\Temp\QOwnNotes-b12708.zip -d "C:\Program Files\qOwnNotes"
unzipExecutable: C:\Users\zingmars\AppData\Local\Temp\QOwnNotes-b12708-unzip.exe
USERDOMAIN: ...
USERDOMAIN_ROAMINGPROFILE: ...
USERNAME: zingmars
USERPROFILE: C:\Users\zingmars
VXIPNPPATH: C:\Program Files (x86)\IVI Foundation\VISA\
windir: C:\WINDOWS
That's interesting. What happens to those dialogs if you select an other language or use default?
Same deal with Automatic language. Some languages do work as expected though, such as German (https://i.imgur.com/kG148v4.png - look at bottom right) and Italian (https://i.imgur.com/yBCckyE.png) while others like English and Spanish (https://i.imgur.com/pLOXvKb.png) seem don't have those buttons translated. Could it be missing strings in translations?
Thank you for testing. No, it's rather the opposite. Strings are translated (from the base language English) to the system's local language regardless of the language used in QOwnNotes. That seems to be an upstream problem in Qt on Windows.
Hm, it could also be a deployment problem of windeployqt in https://github.com/pbek/QOwnNotes/blob/develop/appveyor.yml. I see some Qt library translations missing in the translations folder in the QOwnNotes directory.
@zingmars, could you please test https://ci.appveyor.com/api/buildjobs/xq32ka8efy63ymds/artifacts/appveyor%2FQOwnNotes.zip (from https://ci.appveyor.com/project/pbek/qownnotes/build/windows-b3422/artifacts) for above problems. I tested a Qt 5.9.2 deployment. More languages are included in this build now. Can you please especially also test the dialog buttons in the English language.
Alas - didn't help - https://i.imgur.com/H34JWwy.png https://i.imgur.com/oM5LJij.png
Thank you for testing. Strange, it seemed to work on my German Win 8.1 test system...
Yes, there's no change in behaviour. I'm using Windows 10, so maybe it's a Win10 only issue? I'll download a virtual machine to confirm this when I get the time.
Do the buttons work in Spanish? There definitely should now be a qt_es.qm file in the translations folder. What's the content of your translations folder in the QOwnNotes directory?
I also got German buttons under Windows 10 in English, but in Spanish the buttons are Spanish for me.
Yeah, Spanish has proper buttons.
Contents of the translations folder -
sha256 filename
7ed98691b8a2ed0c9e8ce2c0ca0839362b527880d1ce97644b62075d84d4b8b2 *qt_bg.qm
88fba6a0bcfef775242153286bbb2628e53582c0124810b4c2cdf160aa0efc7e *qt_ca.qm
a4bc7bba8a7b27038415fb64bb719b3ca51f128fc6e6e1bcb25706ee9d4fdc98 *qt_cs.qm
6f760efca258ead8eb31bd3a3748e27fcb6022614ad495355f83408cbb991a29 *qt_da.qm
1ee1f0c3e86da7e992a9482d9eedb8ec66bd04dea54f81f3f09770b1ff432d69 *qt_de.qm
307cef95dd5b36ff215055d427e1885b7fc3650c9224cf76d63056545996ff60 *qt_en.qm
0484ade8dd511e2310bd712e8b421e466f9ff34a77bef68d1220311f4387c856 *qt_es.qm
c10e4f21b48c32d66d4732063145312c77574244fde5cec5d101b438f3214864 *qt_fi.qm
18933f0c77332f572b1784a22bec4ae332c923fecf3c87206dc32beee70316e6 *qt_fr.qm
0983615cf022b2543993aa6d5f65c16eabf344bd49dad89758a1ac322e036e62 *qt_gd.qm
19a8f435880328f9ccda4fecdfc20bac7afae589c07d0e2b5563366e908ac8e3 *qt_he.qm
c02bed85a531d84f47195315e1d3d8d687c5b7137e7d798107473c5f14b1d28c *qt_hu.qm
e322e208772d36a52fc4704e993aa480eca30ff018d29f5eb3b0053f219935c0 *qt_it.qm
ff4b957df1762da313dc64243873519aa8c1e5612b2fddc19e0e333097eb6ef9 *qt_ja.qm
84775ca61545184ad1ad1e80b19798ee624accd63d5de8abc234d0a8228470fd *qt_ko.qm
f2189255501c0e3493473d7ca8d23e53c0cba142948383f6cfc767fa21703849 *qt_lv.qm
4eacff4c8dc09866058fa73b086dbd8e828c46e5bd35384aa34223885e7a228e *qt_pl.qm
49415708461bf01782a3333763903d0aaef83d2466be0972adf6994f3adc6efa *qt_ru.qm
327c7ea3f435372280056157ac5101eb90bcb7d01cf4b3927784a0d1a55eda1a *qt_sk.qm
bc5fbdd1c7667427fcd109294768356f999c124ddf99e627c464ba6d0f681fc5 *qt_uk.qm