pbek
[FEATURE] Add support for Botan 3
Is your feature request related to a problem? Please describe.
Just trying to bump Botan to 3 in Void Linux, but blocked by QOwnNotes supporting only Botan 2 (Void doesn't use the vendored Botan provided by QOwnNotes).
Describe the solution you'd like
Add support for Botan 3.
Probably will need integration in https://github.com/pbek/QOwnNotes/blob/main/src/libraries/botan/botanwrapper.cpp and the qmake and CMake config.
PRs welcome.
Any thoughts, @Waqar144?
afaik botan 3 uses c++ 20, so we can't upgrade to it. However, it might be possible to link to the system botan3.
Hard to test that for me. I didn't even manage to build QOwnNotes with external Botan 2 under NixOS yet. 😅
This appears solved with qt6 6.5.2 from an uneducated view. @Waqar144 can you confirm?
Sorry. I have botan 3 installed and just compiled the latest qt6 release against that - it works fine again over here. @mhmdanas Can you possibly confirm?
@TimB87 From what I can see, QOwnNotes still only supports Botan 2? https://github.com/pbek/QOwnNotes/blob/ab6f39b5b81c3eaa3ba5689abacdaa40e4c5e41c/cmake/FindBotan2.cmake
Maybe you built QOwnNotes with the vendored Botan?
We will not add bundled botan3 support in the near future (read 3-5 years at least), simply because we can't have code that uses anything above C++11. This is so that QON keeps compiling on old systems (win xp, centos7).
However, any PRs that add support for system botan3 conditionally are welcome. It should be possible I believe without any big changes.
Thank you, @Waqar144. Plus, it's easy to use the system Botan (if that works with Botan 3), like for example I did in https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/applications/office/qownnotes/default.nix#L49.