libopenapi-validator icon indicating copy to clipboard operation
libopenapi-validator copied to clipboard

FindPath reports path and operation not found

Open emilien-puget opened this issue 1 year ago • 4 comments

The idea is to have a more precise error reporting from the FindPath function, before it could yield a path not found validation error, with this proposed change we will have a path not found or operation not found error.

this may be a breaking change for some implementation that were reliant on IsPathMissingError to filter any error regarding a find path validation error

emilien-puget avatar Apr 28 '24 15:04 emilien-puget

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.64%. Comparing base (5e5b19b) to head (8318405).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
- Coverage   99.71%   99.64%   -0.07%     
==========================================
  Files          19       19              
  Lines        1758     1703      -55     
==========================================
- Hits         1753     1697      -56     
- Misses          5        6       +1     
Flag Coverage Δ
unittests 99.64% <100.00%> (-0.07%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 28 '24 15:04 codecov[bot]

I think we may need to bump this to a feature release as it's a breaking change, a small one, but a break in previous behavior.

daveshanley avatar Apr 30 '24 14:04 daveshanley

Indeed, do you have in mind some helpers function to ease the update that we could add?

emilien-puget avatar Apr 30 '24 14:04 emilien-puget

I don't know what kind of helper functions we could add to be honest, it's a change in strategy on path validation (albeit a small one).

daveshanley avatar May 03 '24 14:05 daveshanley

we can bundle both your PRs into a minor release.

daveshanley avatar Jul 09 '24 13:07 daveshanley

That'd be great

emilien-puget avatar Jul 09 '24 13:07 emilien-puget