junodb icon indicating copy to clipboard operation
junodb copied to clipboard

go.mod should use fully qualified module path

Open justinfx opened this issue 2 years ago • 5 comments

The go.mod file says module juno, where it should be updated to module github.com/paypal/junodb to be "go get" compatible and properly document the client on pkg.go.dev

justinfx avatar May 21 '23 02:05 justinfx

Hi @justinfx , I would like to work on this.

Ahmadkashif avatar May 21 '23 08:05 Ahmadkashif

Hi @justinfx, take a look at what I tried, it might be a little off as I only had a 1-liner issue description. Let me know if it is what you wanted.

Ahmadkashif avatar May 21 '23 11:05 Ahmadkashif

Hi @Ahmadkashif. Sorry if my description wasn't clear. I had assumed the issue was pretty straightforward via the common Go module documentation. But I hadn't considered you would have also needed to update all of the import paths as well. So definitely not a one line change. Good thing IDE refactoring usually handles it all in one step, and the compiler checks it as well. Changes look good to me!

justinfx avatar May 21 '23 19:05 justinfx

Ref: https://go.dev/ref/mod#module-path

justinfx avatar May 21 '23 19:05 justinfx

I'm happy to help @justinfx .

Let's get the ball rolling.

Ahmadkashif avatar May 21 '23 20:05 Ahmadkashif