feat(version diff)/modified fields only version diff view

[tsemachh]

Description

As an author reviewing the versions I have for a document , I would like to the ability to focus only on the differences I made and not see the entire document. Screencast from 2024-09-05 16-38-40.webm

A checkbox was added to the Version View allowing user to decide if he/she wants to see only modified fields or the entire documents. #7981 - mention this feature and also in discord

• [v] I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

• [v] New feature (non-breaking change which adds functionality)

Checklist:

• [ ] Existing test suite passes locally with my changes (Actually it's stuck on S3 upload test , note related to my code)

One lat question - should we really translate text for all locales ? or we can leave it undefined for now ?(besides english)

[mustiikhalil]

Hey,

Thanks for opening this issue! If you want to try to update the docs, feel free to open a PR for this.

[oxygen]

Sorry to bother you on an unrelated bug,

but flatc generates getRootAs* methods in Swift for you?

It doesn't for me (C# and Java are generated).

Is there something I am missing or not doing? I am doing root_type SomeTable;

[mustiikhalil]

@oxygen so the generated getRootAs* methods are deprecated within swift. the new way is described below. Or you can follow the DocC documentation within xcode

let monster: Monster = try getCheckedRoot(.....)

https://github.com/google/flatbuffers/blob/99fda819058afd617537704abda3f06807aee422/swift/Sources/FlatBuffers/Documentation.docc/Resources/code/swift/swift_code_12.swift#L9

[oxygen]

@mustiikhalil Thank you, this was not intuitive and I was about to compute the offset which would have been ugly. Hopefully the getRootAs functions will be undeprecated and modified into throwing from this checked thing (perhaps on the next major version).

This would save you from updating the tutorial, so we’re now relevant to this thread :)

[mustiikhalil]

Maybe we can add a helper function through the generator, but it will run through this function.

[oxygen]

@mustiikhalil I didn't look yet but I supose getCheckedRoot will throw instead of crashing the program with a fatal error on malformed data. So yeah

[github-actions[bot]]

This issue is stale because it has been open 6 months with no activity. Please comment or label not-stale, or this will be closed in 14 days.

[github-actions[bot]]

This issue was automatically closed due to no activity for 6 months plus the 14 day notice period.