payjoin
Remove hyper and migrate to axum.
This pr is part of the process of transitioning to axum from hyper . Hyper is quite low level and that type of low level details isn't needed for our use case .
Pull Request Checklist
Please confirm the following before requesting review:
- [x] I have disclosed my use of AI in the body of this PR.
- [x] I have read CONTRIBUTING.md and rebased my branch to produce hygienic commits.
Pull Request Test Coverage Report for Build 17893736401
Details
- 160 of 222 (72.07%) changed or added relevant lines in 3 files are covered.
- 5 unchanged lines in 1 file lost coverage.
- Overall coverage increased (+0.2%) to 84.924%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| payjoin-directory/src/main.rs | 0 | 1 | 0.0% |
| payjoin-directory/src/lib.rs | 159 | 220 | 72.27% |
| <!-- | Total: | 160 | 222 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| payjoin-directory/src/lib.rs | 5 | 57.53% |
| <!-- | Total: | 5 |
| Totals | |
|---|---|
| Change from base Build 17883934451: | 0.2% |
| Covered Lines: | 8500 |
| Relevant Lines: | 10009 |
💛 - Coveralls
This pr is collecting some dust and seems close to being finished. @zealsham are you still planning on working on this? And do you need any help?
@arminsabouri , Yes i will work on it. I do not need any help. I temporarily left this pr to foucs on payjoin-cli v1 release related issues, But seeing the "handoff" direction for payjoin-directory, i think i'll juggle the both prs right now. Still at MUR
@zealsham since we will be moving to a payjoin-service crate (which combines directory and ohttp relay services) I think the way forward is to close this PR for payjoin-directory and instead have payjoin-service use axum from the start. I will be writing action items for payjoin-service into GH issues some time today.
okay, i'll go ahead and close the PR @spacebear21. Fully back from travel and getting back into the groove of things. The tracking issue for the directory service is yet to be created though.
Instead of making a new issue I ended up making edits to this existing issue https://github.com/payjoin/rust-payjoin/issues/941 which already covered a lot of the work to be done. It might need a couple more edits for the tower stuff, I can't tell if those items are still relevant for the payjoin-service direction.