protobuf-decoder icon indicating copy to clipboard operation
protobuf-decoder copied to clipboard

Adds support for parsing varint length delimited input data

Open childen opened this issue 2 years ago • 2 comments

Add support for parsing varint length delimited input as used by the parseDelimited and writeDelimited functions in java

childen avatar Dec 07 '23 08:12 childen

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (1dcad14) 69.54% compared to head (69d864d) 61.96%.

Files Patch % Lines
src/ProtobufDisplay.js 0.00% 16 Missing and 2 partials :warning:
src/protobufDecoder.js 38.46% 8 Missing :warning:
src/App.js 33.33% 2 Missing :warning:
src/ProtobufPart.js 0.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
- Coverage   69.54%   61.96%   -7.59%     
==========================================
  Files           8        8              
  Lines         220      255      +35     
  Branches       39       46       +7     
==========================================
+ Hits          153      158       +5     
- Misses         62       90      +28     
- Partials        5        7       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 07 '23 08:12 codecov[bot]

  • Please make sure the build passes (see Netlify status checks)
  • Would it be possible to automatically detect such messages (e.g. by checking if the message length matches the prefixed length though out the message)?
  • Please provide example data so I can verify the functionality
  • Please write unit tests where existing code has unit tests

pawitp avatar Dec 08 '23 22:12 pawitp