Pavlo Tsimura

Results 138 comments of Pavlo Tsimura

**_I have read the CLA Document and I hereby sign the CLA_**

@tgolen please make a sanity check when you have a minute, along with [this comment](https://github.com/Expensify/react-native-onyx/pull/490#issuecomment-1977262222). The only thing that bothers me is that one failing test. I don't fully understand...

> Does that all make sense? Yes, updated the test as you recommended – to verify that the first call for the non-existing keys is made with `undefined`.

@tgolen how terrible is the idea to make the following change? ```js case METHOD.MERGE_COLLECTION: _.each(value, (_value, _key) => promises.push(() => merge(_key, _value))); break; ``` https://github.com/Expensify/react-native-onyx/blob/69b2d5973b4aef19ce783440df55dedb30d4efd2/lib/Onyx.js#L1560-L1562 From what I understand, it...

@tgolen I _think_ I've made a working solution: it updates the data in the correct order, **but** it's a bit slower than the current version. Would it be possible to...

@kidroca could you please help me understand whether the `mergeQueue` was introduced to chain the merge operations within one `update` call, or if there's more to it? How broad is...

I just discovered a behavior that looks like a blocker to me. Explained in detail here: https://github.com/Expensify/react-native-onyx/issues/301#issuecomment-1987950312

I think we should ask for a review from @jjcoffee since he's a C+ on the related issue. Also, we need a full regression test of the App with the...

@tgolen it would be great to get your 👀 on this PR before requesting the full regression test.

While testing the PR deeper, I've noticed another interesting bug: The `mergeCollection` calls each item subscriber every time, even if the data did not actually change – we just fan...