example-async-node-addon icon indicating copy to clipboard operation
example-async-node-addon copied to clipboard
verified publisher icon paulhauner

Async example files updated and compatible to Node.JS v12.9.1

Open numericalfreedom opened this issue 6 years ago • 3 comments

Dear Paul,

thank You very much for Your nice example on an asynchronous function call in NodeJS.

The google V8 JavaScript engine API is changing very fast and also Node.JS has arrived to version 12.9.1 in the meantime. Although there are some very convenient ways for Node.JS API programming like N-API and NAN, I prefer following the roots very closely. After struggling with the API description, Node.JS source code and other difficult details, I have successfully adopted Your example to the latest cutting bleeding edge version.

You will like the code and comparing with the older version, You will see the modifications that have been necessary. You can merge my pullrequest branch and have fun.

Best wishes from old Germany,

Nandor Tamaskovics numericalfreedom on GitHub.

numericalfreedom avatar Sep 04 '19 10:09 numericalfreedom

Dear Paul,

thank You very much for Your nice example on an asynchronous function call in NodeJS.

Last night the latest cutting bleeding edge Node.JS version 12.10.0 has been published.

I have made all adjustments and a new example doAsync.js applying a Promise and an asynchronous function with async/await including the native asynchronous function.

Maybe, You will find my syntax structure little bit strange but I like for its better readability.

You can merge my "pullrequest" branch and have fun.

Best wishes from old Germany,

Nandor Tamaskovics numericalfreedom on GitHub.

numericalfreedom avatar Sep 05 '19 08:09 numericalfreedom

Hi @numericalfreedom, thanks for contributing.

I don't have much to do with this type of programming anymore, I work primarily in Rust now.

So, it's not trivial for me to review this and I don't have the time to dedicate to picking it back up again, unfortunately.

Perhaps the best strategy would be to maintain your own branch and submit a PR to this repo that provides a link on the README.md?

EDIT: sorry, accidental close.

paulhauner avatar Sep 18 '19 01:09 paulhauner

Hi @paulhauner, You can merge the pull request into the main branch, it works fine for the indicated and current version. Unfortunately, the V8 API is changing very fast, so things can look different with higher versions of Node.JS.

Best wishes from old Ger-Money,

@numericalfreedom

numericalfreedom avatar Sep 20 '19 05:09 numericalfreedom