spring-content icon indicating copy to clipboard operation
spring-content copied to clipboard

Is there any plan to implement content sharing?

Open lmtoo opened this issue 6 years ago • 6 comments

create a content link which can access by anonymous user,this link invalid by setting expiration time,or forever valid

lmtoo avatar Feb 24 '20 13:02 lmtoo

For sure @lmtoo. I try to develop Spring Content based on user feedback. That was definitely on my list of items that we could do but until now no one had asked for it.

So, do you need one-time only links? Or expiring links? Or both?

paulcwarren avatar Feb 25 '20 05:02 paulcwarren

both

lmtoo avatar Feb 25 '20 07:02 lmtoo

This would be quite useful to have. I was about to implement this locally as a POC to see if it can be achieved but decided to see if someone had already attempted it and I stumbled upon this issue.

I however wasn't able to decide on whether or not spring-content should track all the relevant metadata for the shared content like TTL etc, or if it should be delegated to the underlying store's native sharing abilities if they exist (for example, the S3 presigned URL feature).

If you have any thoughts on this, do let me know. If we end up settling on an approach, I'd be willing to submit a PR if PRs are welcome.

juja0 avatar Jul 25 '21 08:07 juja0

FYI, the ElasticSearch team created a 'link-rating' app which sort of does that with links instead of contant, a shareable link for each search result. It is showcased, open-sourced & explained here https://www.youtube.com/watch?v=84t_jC3dr3E&t=36m25s

JeroenAdam avatar Aug 20 '21 22:08 JeroenAdam

@JeroenAdam thanks for the link. I will watch that.

@juja0 apologies for the tardy response times. I think both approaches are probably valid, depending on use case. But I like the fact that implementing it in the spring content/spring content rest layer means it would be easy to consume, security is all configured in one place and you are not exposing the underlying details of your implementation. Would love to see a PR if you managed to get something working.

paulcwarren avatar Aug 24 '21 03:08 paulcwarren

@paulcwarren no worries. I didn't get to work on this further due to change in priorities. I will be revisiting this in the coming months. I'll submit a PR once I have something working.

juja0 avatar Aug 26 '21 07:08 juja0