patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard
verified publisher icon patternfly

Bug - Select - Not showing SelectOptions if using inlineFilter and SelectOptions updated

Open jamestalton opened this issue 3 years ago • 2 comments

Describe the problem ACM is using the select component with an inlineFilter and async loading of the SelectOptions: https://github.com/patternfly-labs/react-form-wizard/blob/main/src/inputs/WizAsyncSelect.tsx

Between @patternfly/react-core 4.221.3 and 4.224.1 the component broke because the SelectOptions stopped showing up.

If the inlineFilter is removed, the code works correctly. The other work around is to open the Select twice and the second time it shows the SelectOptions.

How do you reproduce the problem? ~Provide steps to reproduce. A codesandbox demonstrating the problem is appreciated.~

Expected behavior The Select with inlineFilter should show SelectOptions that are async loaded.

Is this issue blocking you? This is not blocking but ACM uses the PatternFly version provided by OCP. If OCP uses this broken version of PatternFly it will severely affect our customers. (Selecting a repo and opening the branches dropdown will not show any branches)

Screenshots ~If applicable, add screenshots to help explain the issue.~

What is your environment?

  • OS: OSX
  • Browser [e.g. chrome, safari]: Chrome
  • Version [e.g. 22]

What is your product and what release date are you targeting? ACM 2.6

Any other information?

jamestalton avatar Jul 27 '22 15:07 jamestalton

I believe this was fixed with this PR: https://github.com/patternfly/patternfly-react/pull/7741 That will be included in the next release.

nicolethoen avatar Jul 27 '22 16:07 nicolethoen

@jamestalton can we close this one?

tlabaj avatar Sep 23 '22 18:09 tlabaj

@KevinFCormier does having a newer version of PatternFly fix this issue for ACM? I believe this was seen in the ACM ArgoCD wizard.

jamestalton avatar Sep 27 '22 15:09 jamestalton

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Nov 26 '22 15:11 stale[bot]

I have verified we don't see the bug on OCP 4.10 or 4.12, but 4.11 is using @patternfly/[email protected]

If I'm reading the tags correctly on the merge commit for that PR, the oldest version this is fixed in is @patternfly/[email protected]

Spinning up an OCP 4.11 instance, to confirm if I can reproduce there.

KevinFCormier avatar Nov 30 '22 19:11 KevinFCormier

I'm not able to reproduce on OCP 4.11 actually. The available options are changing reliably for me. Feel free to close.

KevinFCormier avatar Nov 30 '22 22:11 KevinFCormier