patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

Page - add aria-label prop to components that may overflow

Open thatblindgeye opened this issue 3 years ago • 0 comments

Is this a new component or an extension of an existing one? Page components (PageBreadcrumb, PageGroup, PageNavigation, and PageSection)

Describe the feature See comment https://github.com/patternfly/patternfly-react/pull/7274#pullrequestreview-957153425 for original mention of this issue. Based on this comment, adding an aria-label prop to the above mentioned components could be helpful when they have have the hasOverflowScroll prop passed and the contents would overflow. For the PageGroup component, see comment https://github.com/patternfly/patternfly-react/pull/7293#discussion_r861386901 and how the aria-label was added to a div element.

Additionally, per MDN's Using a section without a heading examples, there could be scenarios where a <section> element does not need a heading element to describe its contents. In these cases, it would also be useful to mention this use case for passing in an aria-label prop to the PageSection component.

Are there visuals for this feature? If applicable, please include examples for each state and for varying widths N/A

Any other information?

thatblindgeye avatar May 03 '22 19:05 thatblindgeye