patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard
verified publisher icon patternfly

fix(Wizard): Fix crash in nav when first sub-step is hidden

Open ochosi opened this issue 1 month ago • 3 comments

Update logic to focus on the first visible sub-step when navigating from a parent step.

What: Fixes #12165

Additional issues:

  • https://github.com/osbuild/image-builder-frontend/issues/3909

ochosi avatar Dec 10 '25 13:12 ochosi

Preview: https://pf-react-pr-12166.surge.sh

A11y report: https://pf-react-pr-12166-a11y.surge.sh

patternfly-build avatar Dec 10 '25 13:12 patternfly-build

@ochosi it looks like there is a linting error that needs to be resolved:

/home/runner/work/patternfly-react/patternfly-react/packages/react-core/src/components/Wizard/WizardNavInternal.tsx
Error:   51:64  error  'subStepIndex' is defined but never used. Allowed unused args must match /^_/u  @typescript-eslint/no-unused-vars

nicolethoen avatar Dec 11 '25 13:12 nicolethoen

@nicolethoen Thanks for the swift review, and apologies for not noticing the linting error. I guess it'd be convenient if the linter would run on all PRs (for everyone not reading the project's README and using yarn lint:all :innocent: )

The linting error is now resolved.

ochosi avatar Dec 11 '25 14:12 ochosi