patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

Bug - LoginPage - Brand is always created even if optional attributes empty

Open rebeccaalpert opened this issue 4 months ago • 1 comments

Describe the problem brandImgSrc and brandImgAlt are marked as optional LoginPage props, but the Brand component gets created anyway: https://github.com/patternfly/patternfly-react/blob/main/packages/react-core/src/components/LoginPage/LoginPage.tsx#L68

Brent Dunn reported on PatternFly Slack that "An empty string ("") was passed to the src attribute" was being logged when these are omitted: https://codesandbox.io/p/devbox/dreamy-fog-qrqy95

How do you reproduce the problem? https://codesandbox.io/p/devbox/dreamy-fog-qrqy95

Expected behavior Optional props should optionally render component.

Is this issue blocking you? Not urgent

What is your product and what release date are you targeting? Not urgent

rebeccaalpert avatar Aug 29 '25 17:08 rebeccaalpert

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Nov 02 '25 11:11 github-actions[bot]