patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

Bug: Chart hover broken due to delaunator package version conflict

Open galkremer1 opened this issue 5 months ago • 3 comments

Describe the problem Hovering over charts does not display the expected label. Instead, an error TypeError: _delaunator.default is not a constructor is thrown. This issue is caused by a version conflict with the delaunator package, where @patternfly/react-topology depends on version 5.0.1, while @patternfly/react-charts uses a dependency (delaunay-find) that expects an older version (4.0.1).

How do you reproduce the problem?

  1. Navigate to a page containing a chart component that utilizes the @patternfly/react-charts library.
  2. Ensure @patternfly/react-topology is also installed in the project.
  3. Hover your mouse over the chart.

Expected behavior When hovering over the chart, the tooltip/label should appear, displaying the data point details without any errors.

Is this issue blocking you? Yes, this issue is a critical blocker as it breaks the primary interaction for data visualization charts, making it impossible for users to inspect data points.

A workaround is to restrict the delaunator dependency to version 4.0.1 in the project's package.json file to resolve the conflict.

What is your environment?

  • OS: Macos 15.6
  • Browser: Chrome
  • Version: 139.0.7258.128 (Official Build) (arm64)

What is your product and what release date are you targeting? Product: kubevirt-plugin

Image

https://github.com/user-attachments/assets/a2f6dfba-9da3-4d8b-b78f-ce12cc6c3463

Expected Behavior:

https://github.com/user-attachments/assets/e640d995-14eb-432c-9858-af2ccdef70f5

galkremer1 avatar Aug 21 '25 16:08 galkremer1

@dlabrecq could we bump the version of delaunay-find in react-charts to match that in topology?

nicolethoen avatar Aug 21 '25 17:08 nicolethoen

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Oct 21 '25 11:10 github-actions[bot]

Victory's VoronoiContainer already appears to be using the latest [email protected] package, which is responsible for [email protected].

See https://github.com/FormidableLabs/victory/blob/main/packages/victory-voronoi-container/package.json

That said, using npm overrides in package.json installed [email protected] for me.

  "overrides": {
    "delaunator": "^5.0.1"
  },

> npm why delaunator

[email protected] overridden
node_modules/delaunator
  delaunator@"^5.0.1" from the root project
  overridden delaunator@"^5.0.1" (was "^4.0.0") from [email protected]
  node_modules/delaunay-find
    delaunay-find@"0.0.6" from [email protected]

dlabrecq avatar Oct 24 '25 14:10 dlabrecq