patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

ToolbarItem - props for width and flex-grow

Open mcoker opened this issue 6 months ago • 3 comments

Looks like we used to have a widths prop for <ToolbarItem /> that was commented out in a core bump (and later removed) - https://github.com/patternfly/patternfly-react/pull/10022. Digging into that, it looks like it was because the CSS variables used with that prop were removed accidentally (https://github.com/patternfly/patternfly/pull/6057/files), which probably broke the core bump, so that feature was commented out. Then we added the vars back in core (https://github.com/patternfly/patternfly/pull/6302/files) and never added the widths prop back.

Also there is a .pf-m-flex-grow[on-{breakpoint}] modifier in core that can go on <ToolbarItem /> and <ToolbarGroup /> that we should add a react prop for.

mcoker avatar Jul 02 '25 20:07 mcoker

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Sep 05 '25 11:09 github-actions[bot]

Hi! I’d like to work on this issue. I’ve implemented a fix locally to add widths and flex-grow responsive props for ToolbarItem, ensuring proper handling for both default and breakpoint-specific classes. I’ll open a PR shortly to address this issue.

khadesamrudhi avatar Oct 20 '25 17:10 khadesamrudhi

Opened PR #12074 to address issue #11910.

khadesamrudhi avatar Oct 20 '25 18:10 khadesamrudhi