patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

Charts - Convert to TypeScript

Open Mash707 opened this issue 9 months ago • 2 comments

Related to #11579, the examples in the following components need to be converted to TypeScript.

  • [x] ChartArea - https://github.com/patternfly/patternfly-react/pull/11721
  • [x] ChartBar - https://github.com/patternfly/patternfly-react/pull/11727
  • [x] ChartBoxPlot - https://github.com/patternfly/patternfly-react/pull/11728
  • [x] ChartBullet - https://github.com/patternfly/patternfly-react/pull/11756 | https://github.com/patternfly/patternfly-react/pull/11758
  • [x] ChartDonut - https://github.com/patternfly/patternfly-react/pull/11818
  • [x] ChartDonutUtilization - https://github.com/patternfly/patternfly-react/pull/11819 | https://github.com/patternfly/patternfly-react/pull/11822
  • [x] ChartLegend - https://github.com/patternfly/patternfly-react/pull/11823
  • [x] ChartLine - https://github.com/patternfly/patternfly-react/pull/11824
  • [ ] ChartPie
  • [ ] ChartScatter
  • [ ] ChartStack
  • [ ] ChartTheme
  • [ ] ChartThreshold
  • [ ] ChartTooltip
  • [ ] Patterns
  • [ ] ResizeObserver
  • [ ] SparkLine

I have not included Skeletons since it is in beta.

Mash707 avatar Mar 26 '25 18:03 Mash707

@thatblindgeye each component has multiple examples.

  • Should I create a single PR for each component updating all examples or one example per PR?
  • The file structure should be similar to react-core i.e. each example having its own .tsx file ?

Mash707 avatar Mar 26 '25 18:03 Mash707

I'd say create 1 PR for each set of component examples. So 1 PR for ChartArea examples, etc. In the PR just make sure to link it to this issue with the "Towards" keyword rather than "Closes"

thatblindgeye avatar Mar 27 '25 12:03 thatblindgeye

All sub-issues completed

thatblindgeye avatar Aug 04 '25 12:08 thatblindgeye