patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

Bug - Modal - error on paste with bitwarden enabled

Open edewit opened this issue 1 year ago • 2 comments

Describe the problem This is a bit of an edge case but when you have a modal with a password input on it on firefox with bitwarden enabled you get an error when you paste a password.

How do you reproduce the problem?

  1. Open https://codesandbox.io/p/sandbox/dreamy-dream-7983p4 with firefox and the bitwarden plugin installed
  2. Paste something into the password field
  3. See the error

Expected behavior It should not give an error

The error is in https://github.com/patternfly/patternfly-react/blob/24c732ea445cd4678cc8901aa22b0d2f80d648cb/packages/react-core/src/components/Modal/Modal.tsx#L155 as it tries to call setAttribute on the injected bitwarden component that is rendered on the password input. and firefox is not allowing this giving a: "Permission denied to access property "setAttribute""

Is this issue blocking you? No, you can disable the bitwarden plugin and then it works

Screenshots image

What is your environment?

  • OS: fedora
  • Browser firefox
  • Version 124.0.1

What is your product and what release date are you targeting?

Any other information?

edewit avatar Apr 02 '24 10:04 edewit

It only happens with Bitwarden Auto fill enabled. Can turn off under "Settings" > "Auto-fill" > "Show auto-fill menu on form fields" > "Off"

marcoleong avatar Apr 18 '24 01:04 marcoleong

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Jun 23 '24 11:06 github-actions[bot]

@marcoleong that is a workaround would be nice if users can still use bitwarden on firefox

edewit avatar Jul 22 '24 06:07 edewit

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Sep 21 '24 11:09 github-actions[bot]

This issue has been closed because it has not had activity since being marked as stale.

github-actions[bot] avatar Oct 06 '24 11:10 github-actions[bot]